mbox series

[v2,0/6] crypto: hisilicon - enable new algorithms of SEC

Message ID 1607598607-8728-1-git-send-email-liulongfang@huawei.com
Headers show
Series crypto: hisilicon - enable new algorithms of SEC | expand

Message

liulongfang Dec. 10, 2020, 11:10 a.m. UTC 
Add support for new algorithms of SEC accelerator on Kunpeng930,
the driver and test case needs to be updated

Longfang Liu (5):
  crypto: hisilicon/sec - add new type of sqe for Kunpeng930
  crypto: hisilicon/sec - add new skcipher mode for SEC
  crypto: hisilicon/sec - add new AEAD mode for SEC
  crypto: hisilicon/sec - fixes some coding style
  crypto: hisilicon/sec - add new algorithm test case

Meng Yu (1):
  crypto: hisilicon/hpre - add version adapt to new algorithms

 arch/arm64/configs/defconfig                |   2 +-
 crypto/testmgr.c                            |  26 +
 crypto/testmgr.h                            |  72 +++
 drivers/crypto/hisilicon/hpre/hpre.h        |   5 +-
 drivers/crypto/hisilicon/hpre/hpre_crypto.c |   4 +-
 drivers/crypto/hisilicon/qm.c               |   4 +-
 drivers/crypto/hisilicon/qm.h               |   4 +-
 drivers/crypto/hisilicon/sec2/sec.h         |  19 +-
 drivers/crypto/hisilicon/sec2/sec_crypto.c  | 861 ++++++++++++++++++++++------
 drivers/crypto/hisilicon/sec2/sec_crypto.h  | 180 +++++-
 drivers/crypto/hisilicon/zip/zip.h          |   4 +-
 drivers/crypto/hisilicon/zip/zip_crypto.c   |   4 +-
 12 files changed, 988 insertions(+), 197 deletions(-)

Comments

Herbert Xu Jan. 2, 2021, 9 p.m. UTC | #1 
On Thu, Dec 10, 2020 at 07:10:01PM +0800, Longfang Liu wrote:
> Add support for new algorithms of SEC accelerator on Kunpeng930,

> the driver and test case needs to be updated

> 

> Longfang Liu (5):

>   crypto: hisilicon/sec - add new type of sqe for Kunpeng930

>   crypto: hisilicon/sec - add new skcipher mode for SEC

>   crypto: hisilicon/sec - add new AEAD mode for SEC


Did you run the fuzz tests on these additions?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
liulongfang Jan. 4, 2021, 8:15 a.m. UTC | #2 
On 2021/1/3 5:00, Herbert Xu wrote:
> On Thu, Dec 10, 2020 at 07:10:01PM +0800, Longfang Liu wrote:

>> Add support for new algorithms of SEC accelerator on Kunpeng930,

>> the driver and test case needs to be updated

>>

>> Longfang Liu (5):

>>   crypto: hisilicon/sec - add new type of sqe for Kunpeng930

>>   crypto: hisilicon/sec - add new skcipher mode for SEC

>>   crypto: hisilicon/sec - add new AEAD mode for SEC

> 

> Did you run the fuzz tests on these additions?

> 

> Thanks,

> 

Hi,
Currently, we have not conducted Fuzz testing.
For SEC driver, we only adds support for these new algorithms
with existing interfaces of Crypto. So, do we need to do Fuzz testing on the existing interfaces?

Thanks,
Longfang
Herbert Xu Jan. 4, 2021, 11:33 a.m. UTC | #3 
On Mon, Jan 04, 2021 at 04:15:13PM +0800, liulongfang wrote:
>

> Currently, we have not conducted Fuzz testing.

> For SEC driver, we only adds support for these new algorithms

> with existing interfaces of Crypto. So, do we need to do Fuzz testing on the existing interfaces?


Please test with CRYPTO_MANAGER_EXTRA_TESTS.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
liulongfang Feb. 5, 2021, 2:05 a.m. UTC | #4 
On 2021/1/4 19:33, Herbert Xu Wrote:
> On Mon, Jan 04, 2021 at 04:15:13PM +0800, liulongfang wrote:

>>

>> Currently, we have not conducted Fuzz testing.

>> For SEC driver, we only adds support for these new algorithms

>> with existing interfaces of Crypto. So, do we need to do Fuzz testing on the existing interfaces?

> 

> Please test with SCRYPTO_MANAGER_EXTRA_TEST.

> 

> Thanks,

> 

After testing with SCRYPTO_MANAGER_EXTRA_TEST, Specifications that our hardware does not support
will cause the test to fail. Before using this patchset,
we need to add software support to solve these problems.
The current patch set needs to be aborted.
Thanks.