Message ID | 1609230801-31721-1-git-send-email-mkshah@codeaurora.org |
---|---|
State | New |
Headers | show |
Series | [v2] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger | expand |
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Tue, 29 Dec 2020 14:03:21 +0530 you wrote: > From: Lina Iyer <ilina@codeaurora.org> > > When triggering a TCS to send its contents, reading back the trigger > value may return an incorrect value. That is because, writing the > trigger may raise an interrupt which could be handled immediately and > the trigger value could be reset in the interrupt handler. > > [...] Here is the summary with links: - [v2] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger https://git.kernel.org/qcom/c/e1d8008179fe You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index 37969dc..0b082ec 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -364,7 +364,7 @@ static void __tcs_set_trigger(struct rsc_drv *drv, int tcs_id, bool trigger) enable = TCS_AMC_MODE_ENABLE; write_tcs_reg_sync(drv, RSC_DRV_CONTROL, tcs_id, enable); enable |= TCS_AMC_MODE_TRIGGER; - write_tcs_reg_sync(drv, RSC_DRV_CONTROL, tcs_id, enable); + write_tcs_reg(drv, RSC_DRV_CONTROL, tcs_id, enable); } }