diff mbox series

[net,v2] net: hns: fix return value check in __lb_other_process()

Message ID 1608970205-24512-1-git-send-email-wangyunjian@huawei.com
State New
Headers show
Series [net,v2] net: hns: fix return value check in __lb_other_process() | expand

Commit Message

wangyunjian Dec. 26, 2020, 8:10 a.m. UTC 
From: Yunjian Wang <wangyunjian@huawei.com>

The function skb_copy() could return NULL, the return value
need to be checked.

Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

David Miller Dec. 28, 2020, 10:59 p.m. UTC | #1 
From: wangyunjian <wangyunjian@huawei.com>

Date: Sat, 26 Dec 2020 16:10:05 +0800

> From: Yunjian Wang <wangyunjian@huawei.com>

> 

> The function skb_copy() could return NULL, the return value

> need to be checked.

> 

> Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support")

> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>


Applied and queued up for -stable, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
index 7165da0ee9aa..a6e3f07caf99 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
@@ -415,6 +415,10 @@  static void __lb_other_process(struct hns_nic_ring_data *ring_data,
 	/* for mutl buffer*/
 	new_skb = skb_copy(skb, GFP_ATOMIC);
 	dev_kfree_skb_any(skb);
+	if (!new_skb) {
+		netdev_err(ndev, "skb alloc failed\n");
+		return;
+	}
 	skb = new_skb;
 
 	check_ok = 0;