| Message ID | 20201224132555.31734-1-zhengyongjun3@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,-next] usb: misc: use DEFINE_MUTEX() for mutex lock | expand |
On Thu, Dec 24, 2020 at 09:25:55PM +0800, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> > --- > drivers/usb/misc/ftdi-elan.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) What changed from v1? That always goes below the --- line. Please fix up and send a v3. thanks, greg k-h
diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index 8a3d9c0c8d8b..bfb538f2cac1 100644 --- a/drivers/usb/misc/ftdi-elan.c +++ b/drivers/usb/misc/ftdi-elan.c @@ -61,7 +61,7 @@ extern struct platform_driver u132_platform_driver; * ftdi_module_lock exists to protect access to global variables * */ -static struct mutex ftdi_module_lock; +static DEFINE_MUTEX(ftdi_module_lock); static int ftdi_instances = 0; static struct list_head ftdi_static_list; /* @@ -2761,7 +2761,6 @@ static int __init ftdi_elan_init(void) { int result; pr_info("driver %s\n", ftdi_elan_driver.name); - mutex_init(&ftdi_module_lock); INIT_LIST_HEAD(&ftdi_static_list); result = usb_register(&ftdi_elan_driver); if (result) {
mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> --- drivers/usb/misc/ftdi-elan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)