| Message ID | 20201106105627.31061-1-qiangqing.zhang@nxp.com |
|---|---|
| Headers | show |
| Series | can: flexcan: add stop mode support for i.MX8QM | expand |
On 11/6/20 11:56 AM, Joakim Zhang wrote: > Add stop mode support for i.MX8QM. > > ChangeLogs: > V4->V5: > * remove patch:firmware: imx: always export SCU symbols, since > it done by commit: 95de5094f5ac firmware: imx: add dummy functions > * rebase to fsl,flexcan.yaml > > V3->V4: > * can_idx->scu_idx. > * return imx_scu_get_handle(&priv->sc_ipc_handle); > * failed_canregister->failed_setup_stop_mode. > > V2->V3: > * define IMX_SC_R_CAN(x) in rsrc.h > * remove error message on -EPROBE_DEFER. > * split disable wakeup patch into separate one. > > V1->V2: > * split ECC fix patches into separate patches. > * free can dev if failed to setup stop mode. > * disable wakeup on flexcan_remove. > * add FLEXCAN_IMX_SC_R_CAN macro helper. > * fsl,can-index->fsl,scu-index. > * move fsl,scu-index and priv->can_idx into > * flexcan_setup_stop_mode_scfw() > * prove failed if failed to setup stop mode. > > Joakim Zhang (5): > dt-bindings: can: flexcan: fix fsl,clk-source property added to linux-can/testing > dt-bindings: can: flexcan: add fsl,scu-index property to indicate a > resource > can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> > FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR > dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN > can: flexcan: add CAN wakeup function for i.MX8QM The others go via linux-can-next/testing, once net/master is merged back to net-next/master to have the yaml bindings. > .../bindings/net/can/fsl,flexcan.yaml | 15 +- > drivers/net/can/flexcan.c | 131 +++++++++++++++--- > include/dt-bindings/firmware/imx/rsrc.h | 1 + > 3 files changed, 124 insertions(+), 23 deletions(-) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> -----Original Message----- > From: Marc Kleine-Budde <mkl@pengutronix.de> > Sent: 2020年11月6日 19:33 > To: Joakim Zhang <qiangqing.zhang@nxp.com>; robh+dt@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de > Cc: kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; > linux-can@vger.kernel.org; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH V5 0/5] can: flexcan: add stop mode support for i.MX8QM > > On 11/6/20 11:56 AM, Joakim Zhang wrote: > > Add stop mode support for i.MX8QM. > > > > ChangeLogs: > > V4->V5: > > * remove patch:firmware: imx: always export SCU symbols, since > > it done by commit: 95de5094f5ac firmware: imx: add dummy functions > > * rebase to fsl,flexcan.yaml > > > > V3->V4: > > * can_idx->scu_idx. > > * return imx_scu_get_handle(&priv->sc_ipc_handle); > > * failed_canregister->failed_setup_stop_mode. > > > > V2->V3: > > * define IMX_SC_R_CAN(x) in rsrc.h > > * remove error message on -EPROBE_DEFER. > > * split disable wakeup patch into separate one. > > > > V1->V2: > > * split ECC fix patches into separate patches. > > * free can dev if failed to setup stop mode. > > * disable wakeup on flexcan_remove. > > * add FLEXCAN_IMX_SC_R_CAN macro helper. > > * fsl,can-index->fsl,scu-index. > > * move fsl,scu-index and priv->can_idx into > > * flexcan_setup_stop_mode_scfw() > > * prove failed if failed to setup stop mode. > > > > Joakim Zhang (5): > > dt-bindings: can: flexcan: fix fsl,clk-source property > > added to linux-can/testing > > > dt-bindings: can: flexcan: add fsl,scu-index property to indicate a > > resource > > can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> > > FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR > > dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN > > can: flexcan: add CAN wakeup function for i.MX8QM > > The others go via linux-can-next/testing, once net/master is merged back to > net-next/master to have the yaml bindings. Hi Marc, How about below patches? I even can't see it in your linux-can-next/testing branch. Are these missed? dt-bindings: can: flexcan: add fsl,scu-index property to indicate a resource can: flexcan: add CAN wakeup function for i.MX8QM Best Regards, Joakim Zhang
On 12/22/20 12:37 PM, Joakim Zhang wrote: > How about below patches? I even can't see it in your linux-can-next/testing branch. Are these missed? > dt-bindings: can: flexcan: add fsl,scu-index property to indicate a resource > can: flexcan: add CAN wakeup function for i.MX8QM The patch "firmware: imx: always export SCU symbols" is not yet in net-next/master, so the flexcan patch will not compile where the SCU is switched off. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Add stop mode support for i.MX8QM. ChangeLogs: V4->V5: * remove patch:firmware: imx: always export SCU symbols, since it done by commit: 95de5094f5ac firmware: imx: add dummy functions * rebase to fsl,flexcan.yaml V3->V4: * can_idx->scu_idx. * return imx_scu_get_handle(&priv->sc_ipc_handle); * failed_canregister->failed_setup_stop_mode. V2->V3: * define IMX_SC_R_CAN(x) in rsrc.h * remove error message on -EPROBE_DEFER. * split disable wakeup patch into separate one. V1->V2: * split ECC fix patches into separate patches. * free can dev if failed to setup stop mode. * disable wakeup on flexcan_remove. * add FLEXCAN_IMX_SC_R_CAN macro helper. * fsl,can-index->fsl,scu-index. * move fsl,scu-index and priv->can_idx into * flexcan_setup_stop_mode_scfw() * prove failed if failed to setup stop mode. Joakim Zhang (5): dt-bindings: can: flexcan: fix fsl,clk-source property dt-bindings: can: flexcan: add fsl,scu-index property to indicate a resource can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN can: flexcan: add CAN wakeup function for i.MX8QM .../bindings/net/can/fsl,flexcan.yaml | 15 +- drivers/net/can/flexcan.c | 131 +++++++++++++++--- include/dt-bindings/firmware/imx/rsrc.h | 1 + 3 files changed, 124 insertions(+), 23 deletions(-)