| Message ID | 20201126223028.3119044-2-niklas.soderlund+renesas@ragnatech.se |
|---|---|
| State | Accepted |
| Commit | d7fdfb6541f3be88d7b4d5ad0aeba7c14548eee8 |
| Headers | show |
| Series | thermal: Add support for R-Car V3U (r8a779a0) | expand |
On Thu, 26 Nov 2020 23:30:26 +0100, Niklas Söderlund wrote: > Add support for R-Car V3U. The V3U IP differs a bit from its siblings in > such way that it have 4 TSC nodes and the interrupts are not routed to > the INTC-AP but to the ECM. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > .../bindings/thermal/rcar-gen3-thermal.yaml | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Niklas-san, Thank you for the patch! > From: Niklas Söderlund, Sent: Friday, November 27, 2020 7:30 AM > > Add support for R-Car V3U. The V3U IP differs a bit from its siblings in > such way that it have 4 TSC nodes and the interrupts are not routed to According to the datasheet, V3U has 5 TSC nodes. And, naming order differs between V3U and other SoCs. - V3U: TSC0 to TSC4 - other SoCs: TSC1 to TSC2 or 3 So, perhaps, we need to modify "items" of "reg" somehow. Best regards, Yoshihiro Shimoda
diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml index f386f2a7c06c95c7..b33a76eeac4e4fed 100644 --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml @@ -26,13 +26,16 @@ properties: - renesas,r8a77961-thermal # R-Car M3-W+ - renesas,r8a77965-thermal # R-Car M3-N - renesas,r8a77980-thermal # R-Car V3H + - renesas,r8a779a0-thermal # R-Car V3U + reg: minItems: 2 - maxItems: 3 + maxItems: 4 items: - description: TSC1 registers - description: TSC2 registers - description: TSC3 registers + - description: TSC4 registers interrupts: items: @@ -55,12 +58,22 @@ properties: required: - compatible - reg - - interrupts - clocks - power-domains - resets - "#thermal-sensor-cells" +if: + not: + properties: + compatible: + contains: + enum: + - renesas,r8a779a0-thermal +then: + required: + - interrupts + additionalProperties: false examples:
Add support for R-Car V3U. The V3U IP differs a bit from its siblings in such way that it have 4 TSC nodes and the interrupts are not routed to the INTC-AP but to the ECM. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- .../bindings/thermal/rcar-gen3-thermal.yaml | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)