diff mbox series

[1/2] dt-bindings: phy: add Amlogic G12A Analog MIPI D-PHY bindings

Message ID 20201123145157.300456-2-narmstrong@baylibre.com
State New
Headers show
Series phy: amlogic: Add support for the G12A Analog MIPI D-PHY | expand

Commit Message

Neil Armstrong Nov. 23, 2020, 2:51 p.m. UTC
The Amlogic G12A SoCs embeds an Analog MIPI D-PHY to communicate with DSI
panels, this adds the bindings.

This Analog D-PHY works with a separate Digital MIPI D-PHY.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 .../phy/amlogic,g12a-mipi-dphy-analog.yaml    | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

Comments

Vinod Koul Dec. 5, 2020, 8:04 a.m. UTC | #1
On 23-11-20, 15:51, Neil Armstrong wrote:
> The Amlogic G12A SoCs embeds an Analog MIPI D-PHY to communicate with DSI

> panels, this adds the bindings.

> 

> This Analog D-PHY works with a separate Digital MIPI D-PHY.


Pls cc Rob on dt binding patches (hint get_maintainer.pl would tell you
do so)

> 

> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

> ---

>  .../phy/amlogic,g12a-mipi-dphy-analog.yaml    | 40 +++++++++++++++++++

>  1 file changed, 40 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> 

> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> new file mode 100644

> index 000000000000..28663552f05b

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> @@ -0,0 +1,40 @@

> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: "http://devicetree.org/schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml#"

> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

> +

> +title: Amlogic G12A MIPI analog PHY

> +

> +maintainers:

> +  - Neil Armstrong <narmstrong@baylibre.com>

> +

> +description: |+

> +  The Everything-Else Power Domains node should be the child of a syscon

> +  node with the required property:

> +

> +  - compatible: Should be the following:

> +                "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"

> +

> +  Refer to the the bindings described in

> +  Documentation/devicetree/bindings/mfd/syscon.yaml

> +

> +properties:

> +  compatible:

> +    const: amlogic,g12a-mipi-dphy-analog

> +

> +  "#phy-cells":

> +    const: 0

> +

> +required:

> +  - compatible

> +  - "#phy-cells"

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    mpphy: phy {

> +          compatible = "amlogic,g12a-mipi-dphy-analog";

> +          #phy-cells = <0>;

> +    };

> -- 

> 2.25.1


-- 
~Vinod
Neil Armstrong Dec. 7, 2020, 9:50 a.m. UTC | #2
Hi,

On 05/12/2020 09:04, Vinod Koul wrote:
> On 23-11-20, 15:51, Neil Armstrong wrote:

>> The Amlogic G12A SoCs embeds an Analog MIPI D-PHY to communicate with DSI

>> panels, this adds the bindings.

>>

>> This Analog D-PHY works with a separate Digital MIPI D-PHY.

> 

> Pls cc Rob on dt binding patches (hint get_maintainer.pl would tell you

> do so)


It's the case.

Neil

> 

>>

>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

>> ---

>>  .../phy/amlogic,g12a-mipi-dphy-analog.yaml    | 40 +++++++++++++++++++

>>  1 file changed, 40 insertions(+)

>>  create mode 100644 Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

>>

>> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

>> new file mode 100644

>> index 000000000000..28663552f05b

>> --- /dev/null

>> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

>> @@ -0,0 +1,40 @@

>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

>> +%YAML 1.2

>> +---

>> +$id: "http://devicetree.org/schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml#"

>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

>> +

>> +title: Amlogic G12A MIPI analog PHY

>> +

>> +maintainers:

>> +  - Neil Armstrong <narmstrong@baylibre.com>

>> +

>> +description: |+

>> +  The Everything-Else Power Domains node should be the child of a syscon

>> +  node with the required property:

>> +

>> +  - compatible: Should be the following:

>> +                "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"

>> +

>> +  Refer to the the bindings described in

>> +  Documentation/devicetree/bindings/mfd/syscon.yaml

>> +

>> +properties:

>> +  compatible:

>> +    const: amlogic,g12a-mipi-dphy-analog

>> +

>> +  "#phy-cells":

>> +    const: 0

>> +

>> +required:

>> +  - compatible

>> +  - "#phy-cells"

>> +

>> +additionalProperties: false

>> +

>> +examples:

>> +  - |

>> +    mpphy: phy {

>> +          compatible = "amlogic,g12a-mipi-dphy-analog";

>> +          #phy-cells = <0>;

>> +    };

>> -- 

>> 2.25.1

>
Rob Herring (Arm) Dec. 7, 2020, 10:44 p.m. UTC | #3
On Mon, Nov 23, 2020 at 03:51:56PM +0100, Neil Armstrong wrote:
> The Amlogic G12A SoCs embeds an Analog MIPI D-PHY to communicate with DSI

> panels, this adds the bindings.

> 

> This Analog D-PHY works with a separate Digital MIPI D-PHY.

> 

> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

> ---

>  .../phy/amlogic,g12a-mipi-dphy-analog.yaml    | 40 +++++++++++++++++++

>  1 file changed, 40 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> 

> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> new file mode 100644

> index 000000000000..28663552f05b

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> @@ -0,0 +1,40 @@

> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: "http://devicetree.org/schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml#"

> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

> +

> +title: Amlogic G12A MIPI analog PHY

> +

> +maintainers:

> +  - Neil Armstrong <narmstrong@baylibre.com>

> +

> +description: |+

> +  The Everything-Else Power Domains node should be the child of a syscon


Everything-Else Power Domains node??

> +  node with the required property:

> +

> +  - compatible: Should be the following:

> +                "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"

> +

> +  Refer to the the bindings described in

> +  Documentation/devicetree/bindings/mfd/syscon.yaml

> +

> +properties:

> +  compatible:

> +    const: amlogic,g12a-mipi-dphy-analog

> +

> +  "#phy-cells":

> +    const: 0

> +

> +required:

> +  - compatible

> +  - "#phy-cells"

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    mpphy: phy {

> +          compatible = "amlogic,g12a-mipi-dphy-analog";

> +          #phy-cells = <0>;

> +    };

> -- 

> 2.25.1

>
Rob Herring (Arm) Dec. 7, 2020, 10:47 p.m. UTC | #4
On Mon, Nov 23, 2020 at 03:51:56PM +0100, Neil Armstrong wrote:
> The Amlogic G12A SoCs embeds an Analog MIPI D-PHY to communicate with DSI

> panels, this adds the bindings.

> 

> This Analog D-PHY works with a separate Digital MIPI D-PHY.

> 

> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

> ---

>  .../phy/amlogic,g12a-mipi-dphy-analog.yaml    | 40 +++++++++++++++++++

>  1 file changed, 40 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> 

> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> new file mode 100644

> index 000000000000..28663552f05b

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

> @@ -0,0 +1,40 @@

> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: "http://devicetree.org/schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml#"

> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

> +

> +title: Amlogic G12A MIPI analog PHY

> +

> +maintainers:

> +  - Neil Armstrong <narmstrong@baylibre.com>

> +

> +description: |+

> +  The Everything-Else Power Domains node should be the child of a syscon

> +  node with the required property:

> +

> +  - compatible: Should be the following:

> +                "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"

> +

> +  Refer to the the bindings described in

> +  Documentation/devicetree/bindings/mfd/syscon.yaml


This schema should be referenced from the parent schema and if you have 
child nodes, you shouldn't be using syscon.yaml.

> +

> +properties:

> +  compatible:

> +    const: amlogic,g12a-mipi-dphy-analog

> +

> +  "#phy-cells":

> +    const: 0

> +

> +required:

> +  - compatible

> +  - "#phy-cells"

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    mpphy: phy {

> +          compatible = "amlogic,g12a-mipi-dphy-analog";

> +          #phy-cells = <0>;


Looks like a dedicated subset of registers, add 'reg' even if Linux 
doesn't use it (currently).

> +    };

> -- 

> 2.25.1

>
Neil Armstrong Dec. 8, 2020, 7:52 a.m. UTC | #5
On 07/12/2020 23:44, Rob Herring wrote:
> On Mon, Nov 23, 2020 at 03:51:56PM +0100, Neil Armstrong wrote:

>> The Amlogic G12A SoCs embeds an Analog MIPI D-PHY to communicate with DSI

>> panels, this adds the bindings.

>>

>> This Analog D-PHY works with a separate Digital MIPI D-PHY.

>>

>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

>> ---

>>  .../phy/amlogic,g12a-mipi-dphy-analog.yaml    | 40 +++++++++++++++++++

>>  1 file changed, 40 insertions(+)

>>  create mode 100644 Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

>>

>> diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

>> new file mode 100644

>> index 000000000000..28663552f05b

>> --- /dev/null

>> +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml

>> @@ -0,0 +1,40 @@

>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

>> +%YAML 1.2

>> +---

>> +$id: "http://devicetree.org/schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml#"

>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

>> +

>> +title: Amlogic G12A MIPI analog PHY

>> +

>> +maintainers:

>> +  - Neil Armstrong <narmstrong@baylibre.com>

>> +

>> +description: |+

>> +  The Everything-Else Power Domains node should be the child of a syscon

> 

> Everything-Else Power Domains node??


Indeed, it's a typo

> 

>> +  node with the required property:

>> +

>> +  - compatible: Should be the following:

>> +                "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"

>> +

>> +  Refer to the the bindings described in

>> +  Documentation/devicetree/bindings/mfd/syscon.yaml

>> +

>> +properties:

>> +  compatible:

>> +    const: amlogic,g12a-mipi-dphy-analog

>> +

>> +  "#phy-cells":

>> +    const: 0

>> +

>> +required:

>> +  - compatible

>> +  - "#phy-cells"

>> +

>> +additionalProperties: false

>> +

>> +examples:

>> +  - |

>> +    mpphy: phy {

>> +          compatible = "amlogic,g12a-mipi-dphy-analog";

>> +          #phy-cells = <0>;

>> +    };

>> -- 

>> 2.25.1

>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml
new file mode 100644
index 000000000000..28663552f05b
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml
@@ -0,0 +1,40 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Amlogic G12A MIPI analog PHY
+
+maintainers:
+  - Neil Armstrong <narmstrong@baylibre.com>
+
+description: |+
+  The Everything-Else Power Domains node should be the child of a syscon
+  node with the required property:
+
+  - compatible: Should be the following:
+                "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"
+
+  Refer to the the bindings described in
+  Documentation/devicetree/bindings/mfd/syscon.yaml
+
+properties:
+  compatible:
+    const: amlogic,g12a-mipi-dphy-analog
+
+  "#phy-cells":
+    const: 0
+
+required:
+  - compatible
+  - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    mpphy: phy {
+          compatible = "amlogic,g12a-mipi-dphy-analog";
+          #phy-cells = <0>;
+    };