| Message ID | 1606357086-9785-1-git-send-email-liulongfang@huawei.com |
|---|---|
| Headers | show |
| Series | crypto: hisilicon - add some new algorithms | expand |
On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: > > diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h b/drivers/crypto/hisilicon/sec2/sec_crypto.h > index 0e933e7..712176b 100644 > --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h > +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.h > @@ -211,6 +219,167 @@ struct sec_sqe { > struct sec_sqe_type2 type2; > }; > > +#pragma pack(4) Please don't use pragma pack. Instead add the attributes as needed to each struct or member. Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Nov 26, 2020 at 10:18:01AM +0800, Longfang Liu wrote: > As the new Kunpeng930 supports some new algorithms, > the driver needs to be updated > > Longfang Liu (4): > crypto: hisilicon/sec - add new type of sqe for Kunpeng930 > crypto: hisilicon/sec - add new skcipher mode for SEC > crypto: hisilicon/sec - add new AEAD mode for SEC > crypto: hisilicon/sec - fixes some coding style > > Meng Yu (1): > crypto: hisilicon/hpre - add version adapt to new algorithms Please include details on whether this has been tested with the self-tests, including the extra fuzz tests. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On 2020/12/4 15:03, Herbert Xu Wrote: > On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: >> >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> index 0e933e7..712176b 100644 >> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h >> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> @@ -211,6 +219,167 @@ struct sec_sqe { >> struct sec_sqe_type2 type2; >> }; >> >> +#pragma pack(4) > > Please don't use pragma pack. Instead add the attributes as > needed to each struct or member. > > Cheers, > OK, I will modify it in next patchset thanks. Longfang
On 2020/12/4 15:05, Herbert Xu wrote: > On Thu, Nov 26, 2020 at 10:18:01AM +0800, Longfang Liu wrote: >> As the new Kunpeng930 supports some new algorithms, >> the driver needs to be updated >> >> Longfang Liu (4): >> crypto: hisilicon/sec - add new type of sqe for Kunpeng930 >> crypto: hisilicon/sec - add new skcipher mode for SEC >> crypto: hisilicon/sec - add new AEAD mode for SEC >> crypto: hisilicon/sec - fixes some coding style >> >> Meng Yu (1): >> crypto: hisilicon/hpre - add version adapt to new algorithms > > Please include details on whether this has been tested with the > self-tests, including the extra fuzz tests. > > Thanks, > All of these new algorithms have been fully tested by the project team, Did any test case tests fail? Thanks. Longfang
On Mon, Dec 07, 2020 at 09:20:05AM +0800, liulongfang wrote: > > Did any test case tests fail? You tell me :) If it passed all of the tests in your testing, please state that in the cover letter or in one of the patches. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On 2020/12/7 9:33, Herbert Xu wrote: > On Mon, Dec 07, 2020 at 09:20:05AM +0800, liulongfang wrote: >> >> Did any test case tests fail? > > You tell me :) > > If it passed all of the tests in your testing, please state that > in the cover letter or in one of the patches. > > Thanks, > OK, I will add new algorithms test results in the next patchset Thanks, Longfang.
On 2020/12/4 15:03, Herbert Xu Wrote: > On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: >> >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> index 0e933e7..712176b 100644 >> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h >> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> @@ -211,6 +219,167 @@ struct sec_sqe { >> struct sec_sqe_type2 type2; >> }; >> >> +#pragma pack(4) > > Please don't use pragma pack. Instead add the attributes as > needed to each struct or member. > > Cheers, > Can I use __attribute__((aligned(n))) instead of #pragma pack(n)? Thanks, Longfang.
On Mon, Dec 07, 2020 at 11:43:38AM +0800, liulongfang wrote: > > Can I use __attribute__((aligned(n))) instead of #pragma pack(n)? We normally just use __aligned(n) in the kernel. Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On 2020/12/7 11:45, Herbert Xu Wrote: > On Mon, Dec 07, 2020 at 11:43:38AM +0800, liulongfang wrote: >> >> Can I use __attribute__((aligned(n))) instead of #pragma pack(n)? > > We normally just use __aligned(n) in the kernel. > > Cheers, > I need to use "__packed __aligned(n)" to make sure the structure length is normal. Is it possible to use "__packed __aligned(n)" in the kernel? Thanks. Longfang.
On Mon, Dec 07, 2020 at 03:46:28PM +0800, liulongfang wrote: > > I need to use "__packed __aligned(n)" to make sure the structure length is normal. > Is it possible to use "__packed __aligned(n)" in the kernel? I don't see why not. Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On 2020/12/7 15:47, Herbert Xu Wrote: > On Mon, Dec 07, 2020 at 03:46:28PM +0800, liulongfang wrote: >> >> I need to use "__packed __aligned(n)" to make sure the structure length is normal. >> Is it possible to use "__packed __aligned(n)" in the kernel? > > I don't see why not. > > Cheers, > Well, I will modify it in this way in the next patchset. Thanks, Longfang.