| Message ID | 20201202204645.23891-6-yung-chuan.liao@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] soundwire: bus: use sdw_update_no_pm when initializing a device | expand |
On 03-12-20, 04:46, Bard Liao wrote: > MODULE_DESCRIPTION("Regmap SoundWire MBQ Module"); > -MODULE_LICENSE("GPL v2"); > +MODULE_LICENSE("GPL"); Why do you want to change this ? > -- > 2.17.1
>> MODULE_DESCRIPTION("Regmap SoundWire MBQ Module"); >> -MODULE_LICENSE("GPL v2"); >> +MODULE_LICENSE("GPL"); > > Why do you want to change this ? We only use MODULE_LICENSE("GPL") for new contributions since 'GPL v2' does not bring any information on the license, is equivalent to 'GPL' and only exists for 'historical reasons', see https://www.kernel.org/doc/html/latest/process/license-rules.html “GPL” Module is licensed under GPL version 2. This does not express any distinction between GPL-2.0-only or GPL-2.0-or-later. The exact license information can only be determined via the license information in the corresponding source files. “GPL v2” Same as “GPL”. It exists for historic reasons. We should have used 'GPL' in the initial regmap MBQ patch but didn't for some reason, this change just realigns with what we intended. That said, this is unrelated to this no_pm patch so could be in a separate one if you preferred it that way.
On Sat, Dec 05, 2020 at 08:52:50AM -0600, Pierre-Louis Bossart wrote: > > > > MODULE_DESCRIPTION("Regmap SoundWire MBQ Module"); > > > -MODULE_LICENSE("GPL v2"); > > > +MODULE_LICENSE("GPL"); > > > > Why do you want to change this ? > > We only use MODULE_LICENSE("GPL") for new contributions since 'GPL v2' does > not bring any information on the license, is equivalent to 'GPL' and only > exists for 'historical reasons', see > > https://www.kernel.org/doc/html/latest/process/license-rules.html > > > “GPL” Module is licensed under GPL version 2. This does not express any > distinction between GPL-2.0-only or GPL-2.0-or-later. The exact license > information can only be determined via the license information in the > corresponding source files. > > “GPL v2” Same as “GPL”. It exists for historic reasons. > > We should have used 'GPL' in the initial regmap MBQ patch but didn't for > some reason, this change just realigns with what we intended. > > That said, this is unrelated to this no_pm patch so could be in a separate > one if you preferred it that way. It should be separate as it does not have anything to do with the real reason this patch was submitted. thanks, greg k-h
On 05-12-20, 17:31, Greg KH wrote: > On Sat, Dec 05, 2020 at 08:52:50AM -0600, Pierre-Louis Bossart wrote: > > > > > > MODULE_DESCRIPTION("Regmap SoundWire MBQ Module"); > > > > -MODULE_LICENSE("GPL v2"); > > > > +MODULE_LICENSE("GPL"); > > > > > > Why do you want to change this ? > > > > We only use MODULE_LICENSE("GPL") for new contributions since 'GPL v2' does > > not bring any information on the license, is equivalent to 'GPL' and only > > exists for 'historical reasons', see > > > > https://www.kernel.org/doc/html/latest/process/license-rules.html > > > > > > “GPL” Module is licensed under GPL version 2. This does not express any > > distinction between GPL-2.0-only or GPL-2.0-or-later. The exact license > > information can only be determined via the license information in the > > corresponding source files. > > > > “GPL v2” Same as “GPL”. It exists for historic reasons. > > > > We should have used 'GPL' in the initial regmap MBQ patch but didn't for > > some reason, this change just realigns with what we intended. > > > > That said, this is unrelated to this no_pm patch so could be in a separate > > one if you preferred it that way. > > It should be separate as it does not have anything to do with the real > reason this patch was submitted. Precisely, this should be a separate patch explaining the motivation behind this change.
diff --git a/drivers/base/regmap/regmap-sdw-mbq.c b/drivers/base/regmap/regmap-sdw-mbq.c index 8ce30650b97c..fe3ac26b66ad 100644 --- a/drivers/base/regmap/regmap-sdw-mbq.c +++ b/drivers/base/regmap/regmap-sdw-mbq.c @@ -15,11 +15,11 @@ static int regmap_sdw_mbq_write(void *context, unsigned int reg, unsigned int va struct sdw_slave *slave = dev_to_sdw_dev(dev); int ret; - ret = sdw_write(slave, SDW_SDCA_MBQ_CTL(reg), (val >> 8) & 0xff); + ret = sdw_write_no_pm(slave, SDW_SDCA_MBQ_CTL(reg), (val >> 8) & 0xff); if (ret < 0) return ret; - return sdw_write(slave, reg, val & 0xff); + return sdw_write_no_pm(slave, reg, val & 0xff); } static int regmap_sdw_mbq_read(void *context, unsigned int reg, unsigned int *val) @@ -29,11 +29,11 @@ static int regmap_sdw_mbq_read(void *context, unsigned int reg, unsigned int *va int read0; int read1; - read0 = sdw_read(slave, reg); + read0 = sdw_read_no_pm(slave, reg); if (read0 < 0) return read0; - read1 = sdw_read(slave, SDW_SDCA_MBQ_CTL(reg)); + read1 = sdw_read_no_pm(slave, SDW_SDCA_MBQ_CTL(reg)); if (read1 < 0) return read1; @@ -98,4 +98,4 @@ struct regmap *__devm_regmap_init_sdw_mbq(struct sdw_slave *sdw, EXPORT_SYMBOL_GPL(__devm_regmap_init_sdw_mbq); MODULE_DESCRIPTION("Regmap SoundWire MBQ Module"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL");