| Message ID | 20201204035128.2219252-1-jonathan.lemon@gmail.com |
|---|---|
| Headers | show |
| Series | Add OpenCompute timecard driver | expand |
On Thu, Dec 03, 2020 at 07:51:28PM -0800, Jonathan Lemon wrote: > The OpenCompute time card is an atomic clock along with > a GPS receiver that provides a Grandmaster clock source > for a PTP enabled network. > > More information is available at http://www.timingcard.com/ > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> Acked-by: Richard Cochran <richardcochran@gmail.com>
On Thu, 3 Dec 2020 19:51:28 -0800 Jonathan Lemon wrote: > +static int __init > +ptp_ocp_init(void) > +{ > + int err; > + > + err = pci_register_driver(&ptp_ocp_driver); > + return err; > +} > + > +static void __exit > +ptp_ocp_fini(void) > +{ > + pci_unregister_driver(&ptp_ocp_driver); > +} > + > +module_init(ptp_ocp_init); > +module_exit(ptp_ocp_fini); FWIW if you want to send a follow up you can replace all this with: module_pci_driver(ptp_ocp_driver);
On Fri, 4 Dec 2020 05:40:11 -0800 Richard Cochran wrote: > On Thu, Dec 03, 2020 at 07:51:28PM -0800, Jonathan Lemon wrote: > > The OpenCompute time card is an atomic clock along with > > a GPS receiver that provides a Grandmaster clock source > > for a PTP enabled network. > > > > More information is available at http://www.timingcard.com/ > > > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> > > Acked-by: Richard Cochran <richardcochran@gmail.com> Applied, thanks!
On Sat, 5 Dec 2020 13:57:18 -0800 Jakub Kicinski wrote: > On Thu, 3 Dec 2020 19:51:28 -0800 Jonathan Lemon wrote: > > +static int __init > > +ptp_ocp_init(void) > > +{ > > + int err; > > + > > + err = pci_register_driver(&ptp_ocp_driver); > > + return err; > > +} > > + > > +static void __exit > > +ptp_ocp_fini(void) > > +{ > > + pci_unregister_driver(&ptp_ocp_driver); > > +} > > + > > +module_init(ptp_ocp_init); > > +module_exit(ptp_ocp_fini); > > FWIW if you want to send a follow up you can replace all this with: > > module_pci_driver(ptp_ocp_driver); Also consider adding yourself a MAINTAINERS entry.
From: Jonathan Lemon <bsd@fb.com> v2->v3: remove dev_info() informational lines v1->v2: make the driver dependent on CONFIG_PCI, for the test robot. move the config option under PTP_1588_CLOCK hierarcy v1: initial submission Jonathan Lemon (1): ptp: Add clock driver for the OpenCompute TimeCard. drivers/ptp/Kconfig | 14 ++ drivers/ptp/Makefile | 1 + drivers/ptp/ptp_ocp.c | 400 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 415 insertions(+) create mode 100644 drivers/ptp/ptp_ocp.c