| Message ID | 20201203225315.1477137-1-arnd@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: samsung: mark PM functions as __maybe_unused | expand |
On Thu, Dec 03, 2020 at 11:53:11PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > I understand this happens with !PM builds. It would be good to mention this in commit msg. With commit msg improved: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof > drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function] > 219 | static int exynos_clkout_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~ > drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: 'exynos_clkout_suspend' defined but not used [-Werror=unused-function] > 210 | static int exynos_clkout_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/clk/samsung/clk-exynos-clkout.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c > index 9ec2f40cc400..e6d6cbf8c4e6 100644 > --- a/drivers/clk/samsung/clk-exynos-clkout.c > +++ b/drivers/clk/samsung/clk-exynos-clkout.c > @@ -207,7 +207,7 @@ static int exynos_clkout_remove(struct platform_device *pdev) > return 0; > } > > -static int exynos_clkout_suspend(struct device *dev) > +static int __maybe_unused exynos_clkout_suspend(struct device *dev) > { > struct exynos_clkout *clkout = dev_get_drvdata(dev); > > @@ -216,7 +216,7 @@ static int exynos_clkout_suspend(struct device *dev) > return 0; > } > > -static int exynos_clkout_resume(struct device *dev) > +static int __maybe_unused exynos_clkout_resume(struct device *dev) > { > struct exynos_clkout *clkout = dev_get_drvdata(dev); > > -- > 2.27.0 >
On Fri, Dec 4, 2020 at 9:36 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Thu, Dec 03, 2020 at 11:53:11PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > I understand this happens with !PM builds. It would be good to mention > this in commit msg. With commit msg improved: > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Thanks for taking a look. I had meant to add a changelog text and failed to notice that this only had the warning message and neither a Fixes tag nor a description when I sent it out. v2 coming. Arnd
diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c index 9ec2f40cc400..e6d6cbf8c4e6 100644 --- a/drivers/clk/samsung/clk-exynos-clkout.c +++ b/drivers/clk/samsung/clk-exynos-clkout.c @@ -207,7 +207,7 @@ static int exynos_clkout_remove(struct platform_device *pdev) return 0; } -static int exynos_clkout_suspend(struct device *dev) +static int __maybe_unused exynos_clkout_suspend(struct device *dev) { struct exynos_clkout *clkout = dev_get_drvdata(dev); @@ -216,7 +216,7 @@ static int exynos_clkout_suspend(struct device *dev) return 0; } -static int exynos_clkout_resume(struct device *dev) +static int __maybe_unused exynos_clkout_resume(struct device *dev) { struct exynos_clkout *clkout = dev_get_drvdata(dev);