mbox series

[v4,0/2] phy: intel: Add Keem Bay USB PHY support

Message ID 20201116120831.32641-1-wan.ahmad.zainie.wan.mohamad@intel.com
Headers show
Series phy: intel: Add Keem Bay USB PHY support | expand

Message

Wan Ahmad Zainie Nov. 16, 2020, 12:08 p.m. UTC
Hi.

Intel Keem Bay USB subsystem incorporates DesignWare USB3.1 controller,
an USB3.1 (Gen1/2) PHY and an USB2.0 PHY. It is a Dual Role Device
(DRD), operating as either a USB host or a USB device.

The patchset is tested on Keem Bay EVM.

Thank you.

Best regards,
Zainie

Changes since v3:
- Revise commit log message of the driver patch.
- In Kconfig, use depends on ARCH_KEEMBAY || COMPILE_TEST.
- Use genmask() to define USS_CPR_MASK.
- In keembay_regmap_config struct, specify .max_register.

Changes since v2:
- Remove dependency on OF in Kconfig.
- Remove header file linux/of.h, and add linux/mod_devicetable.h.
- Add comments for each usleep_range() usage, provide reason for the
  delay.
- Replace usleep_range(2, 10) with udelay(2), as per
  Documentation/timers/timers-howto.txt.
- In _probe(), remove variable np and use dev->of_node directly.

Changes since v1:
- Remove 2 patches that had been merged.
- Rebased to v5.10-rc3.
- Add Rob's Reviewed-by tag in the first patch.
- Use ARCH_KEEMBAY in Kconfig.
- Update #include header; remove <linux/of_address.h>, and add
  <linux/bits.h>.
- Remove unnecessary comments.


Wan Ahmad Zainie (2):
  dt-bindings: phy: Add Intel Keem Bay USB PHY bindings
  phy: intel: Add Keem Bay USB PHY support

 .../bindings/phy/intel,phy-keembay-usb.yaml   |  44 +++
 drivers/phy/intel/Kconfig                     |  12 +
 drivers/phy/intel/Makefile                    |   1 +
 drivers/phy/intel/phy-intel-keembay-usb.c     | 301 ++++++++++++++++++
 4 files changed, 358 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/intel,phy-keembay-usb.yaml
 create mode 100644 drivers/phy/intel/phy-intel-keembay-usb.c

Comments

Vinod Koul Nov. 30, 2020, 10:02 a.m. UTC | #1
On 16-11-20, 20:08, Wan Ahmad Zainie wrote:
> Hi.

> 

> Intel Keem Bay USB subsystem incorporates DesignWare USB3.1 controller,

> an USB3.1 (Gen1/2) PHY and an USB2.0 PHY. It is a Dual Role Device

> (DRD), operating as either a USB host or a USB device.


Applied all, thanks

-- 
~Vinod
Wan Ahmad Zainie Dec. 1, 2020, 2:53 a.m. UTC | #2
Thanks Vinod.

> -----Original Message-----

> From: Vinod Koul <vkoul@kernel.org>

> Sent: Monday, November 30, 2020 6:02 PM

> To: Wan Mohamad, Wan Ahmad Zainie

> <wan.ahmad.zainie.wan.mohamad@intel.com>

> Cc: kishon@ti.com; robh+dt@kernel.org; linux-kernel@vger.kernel.org;

> devicetree@vger.kernel.org; andriy.shevchenko@linux.intel.com;

> mgross@linux.intel.com; Raja Subramanian, Lakshmi Bai

> <lakshmi.bai.raja.subramanian@intel.com>

> Subject: Re: [PATCH v4 0/2] phy: intel: Add Keem Bay USB PHY support

> 

> On 16-11-20, 20:08, Wan Ahmad Zainie wrote:

> > Hi.

> >

> > Intel Keem Bay USB subsystem incorporates DesignWare USB3.1

> > controller, an USB3.1 (Gen1/2) PHY and an USB2.0 PHY. It is a Dual

> > Role Device (DRD), operating as either a USB host or a USB device.

> 

> Applied all, thanks

> 

> --

> ~Vinod