mbox series

[v2,0/2] r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors

Message ID 20201125130148.28724-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Headers show
Series r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors | expand

Message

Prabhakar Mahadev Lad Nov. 25, 2020, 1:01 p.m. UTC
Hi All,

This patch set enables to connect ov7725 sensors on iWave-RZ/G1H Qseven
board.

This patch is based on top of [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/
    renesas-devel.git/log/?h=renesas-arm-dt-for-v5.11

Changes for v2:
* Separated out ov5640 ep into a dtsi

v1: https://patchwork.kernel.org/project/linux-renesas-soc/patch/
    20201120151343.24175-1-prabhakar.mahadev-lad.rj@bp.renesas.com/

Cheers,
Prabhakar

Lad Prabhakar (2):
  ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Separate out ov5640 nodes
  ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add support for 8-bit ov7725
    sensors

 .../boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts    | 104 +++++-------------
 .../dts/r8a7742-iwg21d-q7-dbcm-ov5640.dtsi    |  89 +++++++++++++++
 .../dts/r8a7742-iwg21d-q7-dbcm-ov7725.dtsi    |  77 +++++++++++++
 3 files changed, 194 insertions(+), 76 deletions(-)
 create mode 100644 arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640.dtsi
 create mode 100644 arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725.dtsi

Comments

Prabhakar Mahadev Lad Nov. 25, 2020, 4:26 p.m. UTC | #1
Hi Geert,

> -----Original Message-----

> From: Geert Uytterhoeven <geert@linux-m68k.org>

> Sent: 25 November 2020 16:21

> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>

> Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux-

> renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

> <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das

> <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com>

> Subject: Re: [PATCH v2 0/2] r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors

> 

> Hi Prabhakar,

> 

> On Wed, Nov 25, 2020 at 2:02 PM Lad Prabhakar

> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:

> > This patch set enables to connect ov7725 sensors on iWave-RZ/G1H Qseven

> > board.

> 

> Thanks for your series!

> 

> Do you think it's a valid use case to mix and match ov5640 and ov7725

> cameras? E.g. connect two of each?

>

Yes that is valid case to mix and match. Do you want me to make it configurable too ?

Cheers,
Prabhakar

> Or should all four cameras be of the same type?

>

> Gr{oetje,eeting}s,

> 

>                         Geert

> 

> --

> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

> 

> In personal conversations with technical people, I call myself a hacker. But

> when I'm talking to journalists I just say "programmer" or something like that.

>                                 -- Linus Torvalds
Lad, Prabhakar Nov. 25, 2020, 5:23 p.m. UTC | #2
Hi Geert,

On Wed, Nov 25, 2020 at 4:32 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, Nov 25, 2020 at 5:26 PM Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > -----Original Message-----
> > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Sent: 25 November 2020 16:21
> > > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux-
> > > renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > > <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das
> > > <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com>
> > > Subject: Re: [PATCH v2 0/2] r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors
> > >
> > > Hi Prabhakar,
> > >
> > > On Wed, Nov 25, 2020 at 2:02 PM Lad Prabhakar
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > > This patch set enables to connect ov7725 sensors on iWave-RZ/G1H Qseven
> > > > board.
> > >
> > > Thanks for your series!
> > >
> > > Do you think it's a valid use case to mix and match ov5640 and ov7725
> > > cameras? E.g. connect two of each?
> > >
> > Yes that is valid case to mix and match. Do you want me to make it configurable too ?
>
> If this is a valid use case, then please do so.
>
In that case do we still want to keep the ov7725/ov5640 nodes in
separate dtsi  ?

Cheers,
Prabhakar

> Thanks!
>
> > > Or should all four cameras be of the same type?
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
Geert Uytterhoeven Nov. 25, 2020, 5:34 p.m. UTC | #3
Hi Prabhakar,

On Wed, Nov 25, 2020 at 6:23 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Wed, Nov 25, 2020 at 4:32 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, Nov 25, 2020 at 5:26 PM Prabhakar Mahadev Lad
> > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > > -----Original Message-----
> > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > Sent: 25 November 2020 16:21
> > > > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > Cc: Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>; Linux-Renesas <linux-
> > > > renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > > > <devicetree@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Biju Das
> > > > <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com>
> > > > Subject: Re: [PATCH v2 0/2] r8a7742-iwg21d-q7-dbcm: Add support for ov7725 sensors
> > > >
> > > > On Wed, Nov 25, 2020 at 2:02 PM Lad Prabhakar
> > > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > > > This patch set enables to connect ov7725 sensors on iWave-RZ/G1H Qseven
> > > > > board.
> > > >
> > > > Thanks for your series!
> > > >
> > > > Do you think it's a valid use case to mix and match ov5640 and ov7725
> > > > cameras? E.g. connect two of each?
> > > >
> > > Yes that is valid case to mix and match. Do you want me to make it configurable too ?
> >
> > If this is a valid use case, then please do so.
> >
> In that case do we still want to keep the ov7725/ov5640 nodes in
> separate dtsi  ?

You can, if you define only a single camera in each include file,
and #include four camera include files, with some #define/#undef-ery
around each #include.

Cfr. my suggestion in
https://lore.kernel.org/linux-renesas-soc/CAMuHMdXAB-eUAMSeptptajr0eReHXHFuoR5HZkB-X+AKBUsyxA@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert