Message ID | 20201123111919.233376-1-lee.jones@linaro.org |
---|---|
Headers | show |
Series | Rid W=1 warnings from GPU | expand |
Only skimmed over them, but over all looks sane to me. Series is Acked-by: Christian König <christian.koenig@amd.com> Thanks, Christian. Am 23.11.20 um 12:18 schrieb Lee Jones: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Only 900 (from 5000) to go! > > Lee Jones (40): > drm/radeon/radeon_device: Consume our own header where the prototypes > are located > drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags' > drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s > 'job' param > drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot > misnaming issue > drm/amd/amdgpu/cik_ih: Supply description for 'ih' in > 'cik_ih_{get,set}_wptr()' > drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours > drm/amd/amdgpu/dce_v8_0: Supply description for 'async' > drm/amd/amdgpu/cik_sdma: Supply some missing function param > descriptions > drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues > drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues > drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra > param description > drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header > drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of > 'max_linewidth' > drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place > they are used > drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc > drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues > drm/amd/amdgpu/gfx_v6_0: Supply description for > 'gfx_v6_0_ring_test_ib()'s 'timeout' param > drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting > issues > drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx' > drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse > drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues > drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter > description issues > drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as > __maybe_unused > drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as > __maybe_unused > drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply > 'global_state' description > drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param > descriptions > drm/amd/amdgpu/cik_sdma: Add one and remove another function param > description > drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param > description > drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function > param descriptions > drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions > drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste > drm/msm/msm_drv: Make '_msm_ioremap()' static > drm/amd/amdgpu/gmc_v9_0: Remove unused table > 'ecc_umc_mcumc_status_addrs' > drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions > > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 +- > drivers/gpu/drm/amd/amdgpu/cik_ih.c | 2 + > drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 18 ++- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 33 +++-- > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 +- > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 5 + > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 38 +---- > drivers/gpu/drm/amd/amdgpu/si_dma.c | 14 +- > drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 10 +- > drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 10 +- > drivers/gpu/drm/amd/include/arct_ip_offset.h | 4 +- > .../amd/include/dimgrey_cavefish_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi10_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi12_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi14_ip_offset.h | 2 +- > .../amd/include/sienna_cichlid_ip_offset.h | 2 +- > .../gpu/drm/amd/include/vangogh_ip_offset.h | 2 +- > .../gpu/drm/amd/include/vega20_ip_offset.h | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 75 +++++++++- > .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 88 ------------ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 4 +- > .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++--------- > drivers/gpu/drm/radeon/radeon_device.c | 1 + > 37 files changed, 277 insertions(+), 268 deletions(-) > delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: amd-gfx@lists.freedesktop.org > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: David Airlie <airlied@linux.ie> > Cc: Drew Davenport <ddavenport@chromium.org> > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: Fritz Koenig <frkoenig@google.com> > Cc: Hawking Zhang <Hawking.Zhang@amd.com> > Cc: Huang Rui <ray.huang@amd.com> > Cc: Jerome Glisse <glisse@freedesktop.org> > Cc: Jiansong Chen <Jiansong.Chen@amd.com> > Cc: Jonathan Marek <jonathan@marek.ca> > Cc: Kalyan Thota <kalyan_t@codeaurora.org> > Cc: Likun Gao <Likun.Gao@amd.com> > Cc: linaro-mm-sig@lists.linaro.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: Luben Tuikov <luben.tuikov@amd.com> > Cc: nouveau@lists.freedesktop.org > Cc: Qinglang Miao <miaoqinglang@huawei.com> > Cc: Rob Clark <robdclark@gmail.com> > Cc: Sean Paul <sean@poorly.run> > Cc: Sonny Jiang <sonny.jiang@amd.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Tao Zhou <tao.zhou1@amd.com>
On Mon, 23 Nov 2020, Christian König wrote: > Only skimmed over them, but over all looks sane to me. > > Series is Acked-by: Christian König <christian.koenig@amd.com> Thanks Christian, much appreciated. > Am 23.11.20 um 12:18 schrieb Lee Jones: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Only 900 (from 5000) to go! > > > > Lee Jones (40): > > drm/radeon/radeon_device: Consume our own header where the prototypes > > are located > > drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags' > > drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s > > 'job' param > > drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot > > misnaming issue > > drm/amd/amdgpu/cik_ih: Supply description for 'ih' in [...]
On 2020-11-23 03:19, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Function > parameter or member 'plane' not described in '_dpu_plane_calc_bw' > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Function > parameter or member 'fb' not described in '_dpu_plane_calc_bw' > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:152: warning: Excess > function parameter 'Plane' description in '_dpu_plane_calc_bw' > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:200: warning: Function > parameter or member 'plane' not described in '_dpu_plane_calc_clk' > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:200: warning: Excess > function parameter 'Plane' description in '_dpu_plane_calc_clk' > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:232: warning: Function > parameter or member 'src_width' not described in > '_dpu_plane_calc_fill_level' > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:232: warning: Excess > function parameter 'src_wdith' description in > '_dpu_plane_calc_fill_level' > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:1060: warning: Function > parameter or member 'error' not described in 'dpu_plane_set_error' > > Cc: Rob Clark <robdclark@gmail.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Kalyan Thota <kalyan_t@codeaurora.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > index c0b1d77369e53..cf0084d7cc7c9 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > @@ -142,7 +142,8 @@ static struct dpu_kms *_dpu_plane_get_kms(struct > drm_plane *plane) > > /** > * _dpu_plane_calc_bw - calculate bandwidth required for a plane > - * @Plane: Pointer to drm plane. > + * @plane: Pointer to drm plane. > + * @fb: Pointer to framebuffer associated with the given plane > * Result: Updates calculated bandwidth in the plane state. > * BW Equation: src_w * src_h * bpp * fps * (v_total / v_dest) > * Prefill BW Equation: line src bytes * line_time > @@ -192,7 +193,7 @@ static void _dpu_plane_calc_bw(struct drm_plane > *plane, > > /** > * _dpu_plane_calc_clk - calculate clock required for a plane > - * @Plane: Pointer to drm plane. > + * @plane: Pointer to drm plane. > * Result: Updates calculated clock in the plane state. > * Clock equation: dst_w * v_total * fps * (src_h / dst_h) > */ > @@ -224,7 +225,7 @@ static void _dpu_plane_calc_clk(struct drm_plane > *plane) > * _dpu_plane_calc_fill_level - calculate fill level of the given > source format > * @plane: Pointer to drm plane > * @fmt: Pointer to source buffer format > - * @src_wdith: width of source buffer > + * @src_width: width of source buffer > * Return: fill level corresponding to the source buffer/format or 0 > if error > */ > static int _dpu_plane_calc_fill_level(struct drm_plane *plane, > @@ -1055,6 +1056,7 @@ void dpu_plane_flush(struct drm_plane *plane) > /** > * dpu_plane_set_error: enable/disable error condition > * @plane: pointer to drm_plane structure > + * @error: error value to set > */ > void dpu_plane_set_error(struct drm_plane *plane, bool error) > { _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2020-11-23 03:19, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:247: warning: Excess function > parameter 'Return' description in '_dpu_rm_check_lm_peer' > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Function > parameter or member 'global_state' not described in > '_dpu_rm_check_lm_and_get_connected_blks' > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Excess function > parameter 'Return' description in > '_dpu_rm_check_lm_and_get_connected_blks' > > Cc: Rob Clark <robdclark@gmail.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Drew Davenport <ddavenport@chromium.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > index 0ae8a36ffcff3..fd2d104f0a91d 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > @@ -239,7 +239,7 @@ static bool _dpu_rm_needs_split_display(const > struct msm_display_topology *top) > * @rm: dpu resource manager handle > * @primary_idx: index of primary mixer in rm->mixer_blks[] > * @peer_idx: index of other mixer in rm->mixer_blks[] > - * @Return: true if rm->mixer_blks[peer_idx] is a peer of > + * Return: true if rm->mixer_blks[peer_idx] is a peer of > * rm->mixer_blks[primary_idx] > */ > static bool _dpu_rm_check_lm_peer(struct dpu_rm *rm, int primary_idx, > @@ -264,6 +264,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm > *rm, int primary_idx, > * proposed use case requirements, incl. hardwired dependent blocks > like > * pingpong > * @rm: dpu resource manager handle > + * @global_state: resources shared across multiple kms objects > * @enc_id: encoder id requesting for allocation > * @lm_idx: index of proposed layer mixer in rm->mixer_blks[], > function checks > * if lm, and all other hardwired blocks connected to the lm (pp) > is > @@ -274,7 +275,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm > *rm, int primary_idx, > * mixer in rm->dspp_blks[]. > * @reqs: input parameter, rm requirements for HW blocks needed in the > * datapath. > - * @Return: true if lm matches all requirements, false otherwise > + * Return: true if lm matches all requirements, false otherwise > */ > static bool _dpu_rm_check_lm_and_get_connected_blks(struct dpu_rm *rm, > struct dpu_global_state *global_state, _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel