| Message ID | 20201122163637.3590465-4-niklas.soderlund+renesas@ragnatech.se |
|---|---|
| State | Accepted |
| Commit | 5e67276638765f8dc2327dcf33c0e1f4d5726b7b |
| Headers | show |
| Series | [1/3] adv748x: afe: Select input port when device is reset | expand |
On 22.11.2020 19:36, Niklas Söderlund wrote: > If the device is powered off for example during system suspend to ram > the devices loses its configuration, specially the slave i2c mappings Especially? > and other configuration set at probe time. This renders the device > unusable and only way to recover is to unbind and rebind the device to > the driver to run the probe setup again. > > Add an early resume callback that reinitializes the device and setup the > slave i2c address mappings and other probe time configuration. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> [...] MBR, Sergei
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c index b578a01cfebe7217..4e54148147b9adec 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c @@ -565,6 +565,18 @@ static int adv748x_identify_chip(struct adv748x_state *state) return 0; } +/* ----------------------------------------------------------------------------- + * Suspend / Resume + */ + +static int __maybe_unused adv748x_resume_early(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct adv748x_state *state = i2c_get_clientdata(client); + + return adv748x_reset(state); +} + /* ----------------------------------------------------------------------------- * i2c driver */ @@ -827,10 +839,15 @@ static const struct of_device_id adv748x_of_table[] = { }; MODULE_DEVICE_TABLE(of, adv748x_of_table); +static const struct dev_pm_ops adv748x_pm_ops = { + SET_LATE_SYSTEM_SLEEP_PM_OPS(NULL, adv748x_resume_early) +}; + static struct i2c_driver adv748x_driver = { .driver = { .name = "adv748x", .of_match_table = adv748x_of_table, + .pm = &adv748x_pm_ops, }, .probe_new = adv748x_probe, .remove = adv748x_remove,
If the device is powered off for example during system suspend to ram the devices loses its configuration, specially the slave i2c mappings and other configuration set at probe time. This renders the device unusable and only way to recover is to unbind and rebind the device to the driver to run the probe setup again. Add an early resume callback that reinitializes the device and setup the slave i2c address mappings and other probe time configuration. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/media/i2c/adv748x/adv748x-core.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)