| Message ID | 20201109182206.3037326-24-lee.jones@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,01/23] mtd: mtdpart: Fix misdocumented function parameter 'mtd' | expand |
On Mon, 2020-11-09 at 18:22:06 UTC, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device > drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device > drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device > drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info' > > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Vignesh Raghavendra <vigneshr@ti.com> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: linux-mtd@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
On Thu, 19 Nov 2020, Miquel Raynal wrote: > On Mon, 2020-11-09 at 18:22:06 UTC, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device > > drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device > > drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device > > drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info' > > > > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > > Cc: Richard Weinberger <richard@nod.at> > > Cc: Vignesh Raghavendra <vigneshr@ti.com> > > Cc: Michael Ellerman <mpe@ellerman.id.au> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > Cc: Paul Mackerras <paulus@samba.org> > > Cc: linux-mtd@lists.infradead.org > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Superstar. Thanks for your help Miquel.
Hello, Lee Jones <lee.jones@linaro.org> wrote on Fri, 20 Nov 2020 07:50:00 +0000: > On Thu, 19 Nov 2020, Miquel Raynal wrote: > > > On Mon, 2020-11-09 at 18:22:06 UTC, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device > > > drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device > > > drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device > > > drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info' > > > > > > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > > > Cc: Richard Weinberger <richard@nod.at> > > > Cc: Vignesh Raghavendra <vigneshr@ti.com> > > > Cc: Michael Ellerman <mpe@ellerman.id.au> > > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > > Cc: Paul Mackerras <paulus@samba.org> > > > Cc: linux-mtd@lists.infradead.org > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. > > Superstar. Thanks for your help Miquel. > haha :) well it was late, I applied these patches to the wrong branch, I just moved them to the mtd/next branch, sorry for the push -f :) Cheers, Miquèl
diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c index 0b757d9ba2f6b..6950a87648151 100644 --- a/drivers/mtd/devices/powernv_flash.c +++ b/drivers/mtd/devices/powernv_flash.c @@ -126,6 +126,7 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op, } /** + * powernv_flash_read * @mtd: the device * @from: the offset to read from * @len: the number of bytes to read @@ -142,6 +143,7 @@ static int powernv_flash_read(struct mtd_info *mtd, loff_t from, size_t len, } /** + * powernv_flash_write * @mtd: the device * @to: the offset to write to * @len: the number of bytes to write @@ -158,6 +160,7 @@ static int powernv_flash_write(struct mtd_info *mtd, loff_t to, size_t len, } /** + * powernv_flash_erase * @mtd: the device * @erase: the erase info * Returns 0 if erase successful or -ERRNO if an error occurred @@ -176,7 +179,7 @@ static int powernv_flash_erase(struct mtd_info *mtd, struct erase_info *erase) /** * powernv_flash_set_driver_info - Fill the mtd_info structure and docg3 - * structure @pdev: The platform device + * @dev: The device structure * @mtd: The structure to fill */ static int powernv_flash_set_driver_info(struct device *dev,
Fixes the following W=1 kernel build warning(s): drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info' Cc: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Richard Weinberger <richard@nod.at> Cc: Vignesh Raghavendra <vigneshr@ti.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: linux-mtd@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mtd/devices/powernv_flash.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/