diff mbox series

[53/78] blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats

Message ID 20201116145809.410558-54-hch@lst.de
State New
Headers show
Series [01/78] block: remove the call to __invalidate_device in check_disk_size_change | expand

Commit Message

Christoph Hellwig Nov. 16, 2020, 2:57 p.m. UTC 
disk_get_part needs to be paired with a disk_put_part.

Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-cgroup.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Hannes Reinecke Nov. 20, 2020, 7:25 a.m. UTC | #1 
On 11/16/20 3:57 PM, Christoph Hellwig wrote:
> disk_get_part needs to be paired with a disk_put_part.

> 

> Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")

> Signed-off-by: Christoph Hellwig <hch@lst.de>

> ---

>   block/blk-cgroup.c | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c

> index c68bdf58c9a6e1..54fbe1e80cc41a 100644

> --- a/block/blk-cgroup.c

> +++ b/block/blk-cgroup.c

> @@ -849,6 +849,7 @@ static void blkcg_fill_root_iostats(void)

>   			blkg_iostat_set(&blkg->iostat.cur, &tmp);

>   			u64_stats_update_end(&blkg->iostat.sync);

>   		}

> +		disk_put_part(part);

>   	}

>   }

>   

> 

Reviewed-by: Hannes Reinecke <hare@suse.de>


Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
diff mbox series

Patch

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index c68bdf58c9a6e1..54fbe1e80cc41a 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -849,6 +849,7 @@  static void blkcg_fill_root_iostats(void)
 			blkg_iostat_set(&blkg->iostat.cur, &tmp);
 			u64_stats_update_end(&blkg->iostat.sync);
 		}
+		disk_put_part(part);
 	}
 }