| Message ID | 20201112110204.2083435-6-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | cd536aa5b438351ea170d5e5f0cd75650eaab005 |
| Headers | show |
| Series | Rid W=1 issues from Input | expand |
> -----Original Message----- > From: Lee Jones [mailto:lee.jones@linaro.org] > Sent: 2020年11月12日 19:02 > To: lee.jones@linaro.org > Cc: linux-kernel@vger.kernel.org; Dmitry Torokhov > <dmitry.torokhov@gmail.com>; Shawn Guo <shawnguo@kernel.org>; Sascha > Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; > dl-linux-imx <linux-imx@nxp.com>; Haibo Chen <haibo.chen@freescale.com>; > linux-input@vger.kernel.org > Subject: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused > variable 'value' > > Fixes the following W=1 kernel build warning(s): > > drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’: > drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set > but not used [-Wunused-but-set-variable] > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: Haibo Chen <haibo.chen@freescale.com> > Cc: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/input/touchscreen/imx6ul_tsc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/imx6ul_tsc.c > b/drivers/input/touchscreen/imx6ul_tsc.c > index cd369f9ac5e60..e1852f7d4d31e 100644 > --- a/drivers/input/touchscreen/imx6ul_tsc.c > +++ b/drivers/input/touchscreen/imx6ul_tsc.c > @@ -304,11 +304,10 @@ static irqreturn_t adc_irq_fn(int irq, void *dev_id) > { > struct imx6ul_tsc *tsc = dev_id; > u32 coco; > - u32 value; > > coco = readl(tsc->adc_regs + REG_ADC_HS); > if (coco & 0x01) { > - value = readl(tsc->adc_regs + REG_ADC_R0); > + readl(tsc->adc_regs + REG_ADC_R0); > complete(&tsc->completion); > } > Reviewed-by: Haibo Chen <haibo.chen@nxp.com> > -- > 2.25.1
On Thu, Nov 12, 2020 at 11:01:54AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’: > drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable] > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: Haibo Chen <haibo.chen@freescale.com> > Cc: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied, thank you. -- Dmitry
On Thu, 12 Nov 2020, Dmitry Torokhov wrote: > On Thu, Nov 12, 2020 at 11:01:54AM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’: > > drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable] > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: Sascha Hauer <s.hauer@pengutronix.de> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > > Cc: Fabio Estevam <festevam@gmail.com> > > Cc: NXP Linux Team <linux-imx@nxp.com> > > Cc: Haibo Chen <haibo.chen@freescale.com> > > Cc: linux-input@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Applied, thank you. Good morning Dmitry, Are you planning on finishing this review? About half of the patches are unreviewed and there are a couple of open questions on others. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index cd369f9ac5e60..e1852f7d4d31e 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -304,11 +304,10 @@ static irqreturn_t adc_irq_fn(int irq, void *dev_id) { struct imx6ul_tsc *tsc = dev_id; u32 coco; - u32 value; coco = readl(tsc->adc_regs + REG_ADC_HS); if (coco & 0x01) { - value = readl(tsc->adc_regs + REG_ADC_R0); + readl(tsc->adc_regs + REG_ADC_R0); complete(&tsc->completion); }
Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’: drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: Haibo Chen <haibo.chen@freescale.com> Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/input/touchscreen/imx6ul_tsc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1