diff mbox series

[v2,net-next] net: udp: remove redundant initialization in udp_gro_complete

Message ID 5faa01d5.1c69fb81.8451c.cb5b@mx.google.com
State Superseded
Headers show
Series [v2,net-next] net: udp: remove redundant initialization in udp_gro_complete | expand

Commit Message

Menglong Dong Nov. 10, 2020, 2:57 a.m. UTC 
From: Menglong Dong <dong.menglong@zte.com.cn>

The initialization for 'err' with '-ENOSYS' is redundant and
can be removed, as it is updated soon and not used.

Changes since v1:
- Move the err declaration below struct sock *sk

Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
---
 net/ipv4/udp_offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Nov. 12, 2020, 10:47 p.m. UTC | #1 
On Mon,  9 Nov 2020 21:57:58 -0500 menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>

> 

> The initialization for 'err' with '-ENOSYS' is redundant and

> can be removed, as it is updated soon and not used.

> 

> Changes since v1:

> - Move the err declaration below struct sock *sk

> 

> Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>


Applied, thanks!
diff mbox series

Patch

diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
index b8b1fde..54c9533 100644
--- a/net/ipv4/udp_offload.c
+++ b/net/ipv4/udp_offload.c
@@ -554,8 +554,8 @@  int udp_gro_complete(struct sk_buff *skb, int nhoff,
 {
 	__be16 newlen = htons(skb->len - nhoff);
 	struct udphdr *uh = (struct udphdr *)(skb->data + nhoff);
-	int err = -ENOSYS;
 	struct sock *sk;
+	int err;
 
 	uh->len = newlen;