diff mbox series

[net-next] net: phy: microchip_t1: Don't set .config_aneg

Message ID 20201109091605.3951c969@xhacker.debian
State New
Headers show
Series [net-next] net: phy: microchip_t1: Don't set .config_aneg | expand

Commit Message

Jisheng Zhang Nov. 9, 2020, 1:16 a.m. UTC 
The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
needed, because the phy core will call genphy_config_aneg() if the
.config_aneg is NULL.

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
 drivers/net/phy/microchip_t1.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrew Lunn Nov. 9, 2020, 5:36 p.m. UTC | #1 
On Mon, Nov 09, 2020 at 09:16:05AM +0800, Jisheng Zhang wrote:
> The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
> needed, because the phy core will call genphy_config_aneg() if the
> .config_aneg is NULL.
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
diff mbox series

Patch

diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
index fed3e395f18e..1c9900162619 100644
--- a/drivers/net/phy/microchip_t1.c
+++ b/drivers/net/phy/microchip_t1.c
@@ -219,7 +219,6 @@  static struct phy_driver microchip_t1_phy_driver[] = {
 		.features       = PHY_BASIC_T1_FEATURES,
 
 		.config_init	= lan87xx_config_init,
-		.config_aneg    = genphy_config_aneg,
 
 		.ack_interrupt  = lan87xx_phy_ack_interrupt,
 		.config_intr    = lan87xx_phy_config_intr,