mbox series

[v2,0/5] add exynos4412-based p4note device family support

Message ID 20201031175836.47745-1-martin.juecker@gmail.com
Headers show
Series add exynos4412-based p4note device family support | expand

Message

Martin Jücker Oct. 31, 2020, 5:58 p.m. UTC 
Hello,

after lots of research and trial and error, this is my first
contribution to the linux kernel.

These patches lay the foundation for supporting the Samsung Galaxy
Note 10.1 device family. To the best of my knowledge there are around
16 devices which use almost identical hardware inside with exceptions
being the modem and one of the sensors. The first instance which I'm
currently testing on is the N8010 which is the wifi only version that
is identical to the N8013. There are some missing components still,
but it's a start.

v1: https://lore.kernel.org/linux-samsung-soc/20201024144421.34435-1-martin.juecker@gmail.com/

Changes in v2 (proposed by Marek and Krzysztof)
- lots of label adjustments, some removed
- unused ehci node removed
- unused serials removed
- compatible string is now samsung,n8010 instead of samsung,n801x
- removed unused imports
- voltage regulator name for TSP changed to match vendor kernel
- i2c numbering starting from 1 now
- two missing gpio configurations added
- added vdd supply to adc node
- added all regulators to max77686 node
- pinctrl configs sorted by pin name


Cheers
Martin

Comments

Rob Herring (Arm) Nov. 4, 2020, 8:03 p.m. UTC | #1 
On Sat, 31 Oct 2020 18:58:33 +0100, Martin Jücker wrote:
> Document the GT-N8010/GT-N8013 device binding and the p4note common
> binding that it is based on.
> 
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
>  .../devicetree/bindings/arm/samsung/samsung-boards.yaml   | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Martin Jücker Nov. 6, 2020, 8:45 p.m. UTC | #2 
On Wed, Nov 04, 2020 at 02:03:48PM -0600, Rob Herring wrote:
> On Sat, 31 Oct 2020 18:58:33 +0100, Martin Jücker wrote:
> > Document the GT-N8010/GT-N8013 device binding and the p4note common
> > binding that it is based on.
> > 
> > Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> > ---
> >  .../devicetree/bindings/arm/samsung/samsung-boards.yaml   | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> 
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.
> 

I wasn't aware of this but it makes sense. I actually changed the board
compatible from samsung,n801x to samsung,n8010 - I guess that would
still be ok to add a reviewed-by in this case?

Cheers
Martin