| Message ID | 20201104162427.2984742-3-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 6cffd88c2f7d4b552a0bc3ba31af3c113de4d0b5 |
| Headers | show |
| Series | Rid W=1 issues from Input | expand |
Hi Lee, On Wed, Nov 04, 2020 at 04:24:09PM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' not described in 'cyapa_i2c_write' > drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' description in 'cyapa_i2c_write' > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Henrik Rydberg <rydberg@bitmath.org> > Cc: Dudley Du <dudl@cypress.com> > Cc: Daniel Kurtz <djkurtz@chromium.org> > Cc: Benson Leung <bleung@chromium.org> > Cc: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Benson Leung <bleung@chromium.org> > --- > drivers/input/mouse/cyapa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c > index c675f156948b5..dacf7c0e43f98 100644 > --- a/drivers/input/mouse/cyapa.c > +++ b/drivers/input/mouse/cyapa.c > @@ -119,7 +119,7 @@ static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 reg, size_t len, > /** > * cyapa_i2c_write - Execute i2c block data write operation > * @cyapa: Handle to this driver > - * @ret: Offset of the data to written in the register map > + * @reg: Offset of the data to written in the register map > * @len: number of bytes to write > * @values: Data to be written > * > -- > 2.25.1 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org
On Wed, Nov 04, 2020 at 04:24:09PM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' not described in 'cyapa_i2c_write' > drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' description in 'cyapa_i2c_write' > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Henrik Rydberg <rydberg@bitmath.org> > Cc: Dudley Du <dudl@cypress.com> > Cc: Daniel Kurtz <djkurtz@chromium.org> > Cc: Benson Leung <bleung@chromium.org> > Cc: linux-input@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied, thank you. -- Dmitry
diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c index c675f156948b5..dacf7c0e43f98 100644 --- a/drivers/input/mouse/cyapa.c +++ b/drivers/input/mouse/cyapa.c @@ -119,7 +119,7 @@ static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 reg, size_t len, /** * cyapa_i2c_write - Execute i2c block data write operation * @cyapa: Handle to this driver - * @ret: Offset of the data to written in the register map + * @reg: Offset of the data to written in the register map * @len: number of bytes to write * @values: Data to be written *
Fixes the following W=1 kernel build warning(s): drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' not described in 'cyapa_i2c_write' drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' description in 'cyapa_i2c_write' Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Henrik Rydberg <rydberg@bitmath.org> Cc: Dudley Du <dudl@cypress.com> Cc: Daniel Kurtz <djkurtz@chromium.org> Cc: Benson Leung <bleung@chromium.org> Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/input/mouse/cyapa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)