mbox series

[i2c-next,v2,0/6] i2c: Incremental fixes for Mellanox BlueField I2C

Message ID cover.1604432921.git.kblaiech@nvidia.com
Headers show
Series i2c: Incremental fixes for Mellanox BlueField I2C | expand

Message

Khalil Blaiech Nov. 3, 2020, 7:54 p.m. UTC 
This set of fixes tends to complement the upstream effort of the
driver code and aims to address the following issues:
  - Convert the DT file to a YAML schema to be consistent with the
  latest kernel releases.
  - Fix build issues reproted by the kernel test robot.
  - Apply a couple of changes to the driver code to include bug fixes.
  - Keep the MAINTAINER info up-to-date.
---
v1->v2:
	- Address yamllint and dtschema/dt warning/errors.
	- Dual license the YAML schema by adding BSD-2-Clause.
---

Khalil Blaiech (6):
  i2c: mlxbf: Add CONFIG_ACPI to guard ACPI function call
  i2c: mlxbf: Fix resrticted cast warning of sparse
  i2c: mlxbf: Remove unecessary wrapper functions
  i2c: mlxbf: Update reference clock frequency
  i2c: mlxbf: Update author and maintainer email info
  dt-bindings: i2c: Convert DT file to YAML schema

 .../devicetree/bindings/i2c/mellanox,i2c-mlxbf.txt |  42 -----
 .../bindings/i2c/mellanox,i2c-mlxbf.yaml           |  80 ++++++++
 MAINTAINERS                                        |   3 +-
 drivers/i2c/busses/i2c-mlxbf.c                     | 204 +++++++++------------
 4 files changed, 168 insertions(+), 161 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml

Comments

Wolfram Sang Nov. 6, 2020, 2:52 p.m. UTC | #1 
On Tue, Nov 03, 2020 at 02:54:38PM -0500, Khalil Blaiech wrote:
> The build fails with "implicit declaration of function

> 'acpi_device_uid'" error. Thus, protect ACPI function calls

> from being called when CONFIG_ACPI is disabled.

> 

> Fixes: b5b5b32081cd206b ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")

> Reported-by: kernel test robot <lkp@intel.com>

> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

> Reviewed-by: Vadim Pasternak <vadimp@nvidia.com>

> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>


Applied to for-current, thanks!
Wolfram Sang Nov. 6, 2020, 2:53 p.m. UTC | #2 
On Tue, Nov 03, 2020 at 02:54:40PM -0500, Khalil Blaiech wrote:
> Few wrapper functions are useless and can be inlined. So

> delete mlxbf_i2c_read() and mlxbf_i2c_write() and replace

> them with readl() and writel(), respectively. Also delete

> mlxbf_i2c_read_data() and mlxbf_i2c_write() and replace

> them with ioread32be() and iowrite32be(), respectively.

> 

> Fixes: b5b5b32081cd206b ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")

> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

> Reviewed-by: Vadim Pasternak <vadimp@nvidia.com>

> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>


Applied to for-current, thanks!
Wolfram Sang Nov. 6, 2020, 2:53 p.m. UTC | #3 
On Tue, Nov 03, 2020 at 02:54:42PM -0500, Khalil Blaiech wrote:
> Correct the email addresses of the author and the maintainer

> of the Mellanox BlueField I2C driver.

> 

> Fixes: b5b5b32081cd206b ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")

> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>


Applied to for-current, thanks!