| Message ID | 20201031174721.1080756-1-andrew@lunn.ch |
|---|---|
| Headers | show |
| Series | xilinx_emaclite W=1 fixes | expand |
On 31. 10. 20 18:47, Andrew Lunn wrote: > The txqueue parameter to the watchdog callback is unused in this > driver. But it still needs to be documented. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > --- > drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > index 0c26f5bcc523..2c98e4cc07a5 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > @@ -518,6 +518,7 @@ static int xemaclite_set_mac_address(struct net_device *dev, void *address) > /** > * xemaclite_tx_timeout - Callback for Tx Timeout > * @dev: Pointer to the network device > + * @txqueue: Unused > * > * This function is called when Tx time out occurs for Emaclite device. > */ > Fixes: 0290bd291cc0 ("netdev: pass the stuck queue to the timeout handler") Reviewed-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal
On 31. 10. 20 18:47, Andrew Lunn wrote: > To improve build testing of this driver, add COMPILE_TEST support. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > --- > drivers/net/ethernet/xilinx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig > index d0d0d4fe9d40..3b2137d1f4c6 100644 > --- a/drivers/net/ethernet/xilinx/Kconfig > +++ b/drivers/net/ethernet/xilinx/Kconfig > @@ -18,7 +18,7 @@ if NET_VENDOR_XILINX > > config XILINX_EMACLITE > tristate "Xilinx 10/100 Ethernet Lite support" > - depends on PPC32 || MICROBLAZE || ARCH_ZYNQ || MIPS > + depends on PPC32 || MICROBLAZE || ARCH_ZYNQ || MIPS || COMPILE_TEST > select PHYLIB > help > This driver supports the 10/100 Ethernet Lite from Xilinx. > Acked-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal
kerneldoc, pointer issues, and add COMPILE_TEST support to easy finding future issues via build testing. Andrew Lunn (3): drivers: net: xilinx_emaclite: Add missing parameter kerneldoc drivers: net: xilinx_emaclite: Fix -Wpointer-to-int-cast warnings with W=1 drivers: net: xilinx_emaclite: Add COMPILE_TEST support drivers/net/ethernet/xilinx/Kconfig | 2 +- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-)