| Message ID | 20201030141136.1013521-1-mst@redhat.com |
|---|---|
| Headers | show |
| Series | pc,pci,vhost,virtio: misc fixes | expand |
Patchew URL: https://patchew.org/QEMU/20201030141136.1013521-1-mst@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201030141136.1013521-1-mst@redhat.com Subject: [PULL 00/15] pc,pci,vhost,virtio: misc fixes === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu a19d4bc..d03e884 master -> master - [tag update] patchew/1604030281-112946-1-git-send-email-zhengchuan@huawei.com -> patchew/1604030281-112946-1-git-send-email-zhengchuan@huawei.com - [tag update] patchew/20201029093306.1063879-1-philmd@redhat.com -> patchew/20201029093306.1063879-1-philmd@redhat.com * [new tag] patchew/20201030141136.1013521-1-mst@redhat.com -> patchew/20201030141136.1013521-1-mst@redhat.com Switched to a new branch 'test' f8ab72c intel_iommu: Fix two misuse of "0x%u" prints aeb07bf virtio: skip guest index check on device load e013e46 vhost-blk: set features before setting inflight feature b6d6a5d pci: Disallow improper BAR registration for type 1 53dc503 pci: Change error_report to assert(3) a577a4f pci: advertise a page aligned ATS 660b206 pc: Implement -no-hpet as sugar for -machine hpet=on 164a904 vhost: Don't special case vq->used_phys in vhost_get_log_size() a1d332a pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level bbf25ac hw/pci: Extract pci_bus_change_irq_level() from pci_change_irq_level() 8de7382 hw/virtio/vhost-vdpa: Fix Coverity CID 1432864 80e32f6 acpi/crs: Support ranges > 32b for hosts 0eaee2c acpi/crs: Prevent bad ranges for host bridges fd09a4c vhost-vsock: set vhostfd to non-blocking mode fc8dc67 vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver === OUTPUT BEGIN === 1/15 Checking commit fc8dc6798809 (vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver) 2/15 Checking commit fd09a4cbcbd8 (vhost-vsock: set vhostfd to non-blocking mode) 3/15 Checking commit 0eaee2c681ea (acpi/crs: Prevent bad ranges for host bridges) 4/15 Checking commit 80e32f603ced (acpi/crs: Support ranges > 32b for hosts) 5/15 Checking commit 8de73825fd26 (hw/virtio/vhost-vdpa: Fix Coverity CID 1432864) 6/15 Checking commit bbf25ac3c419 (hw/pci: Extract pci_bus_change_irq_level() from pci_change_irq_level()) 7/15 Checking commit a1d332aa3ca8 (pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level) 8/15 Checking commit 164a904d579f (vhost: Don't special case vq->used_phys in vhost_get_log_size()) 9/15 Checking commit 660b206b990b (pc: Implement -no-hpet as sugar for -machine hpet=on) WARNING: Block comments use a leading /* on a separate line #53: FILE: hw/i386/pc.c:1152: + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 WARNING: Block comments should align the * on each line #54: FILE: hw/i386/pc.c:1153: + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 + * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, total: 0 errors, 2 warnings, 127 lines checked Patch 9/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/15 Checking commit a577a4ff801e (pci: advertise a page aligned ATS) 11/15 Checking commit 53dc50301f47 (pci: Change error_report to assert(3)) 12/15 Checking commit b6d6a5d5fd42 (pci: Disallow improper BAR registration for type 1) 13/15 Checking commit e013e462e230 (vhost-blk: set features before setting inflight feature) ERROR: trailing whitespace #45: FILE: hw/virtio/vhost.c:1651: + $ ERROR: trailing whitespace #50: FILE: hw/virtio/vhost.c:1656: + $ total: 2 errors, 0 warnings, 43 lines checked Patch 13/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/15 Checking commit aeb07bf1ef04 (virtio: skip guest index check on device load) 15/15 Checking commit f8ab72c9b7cf (intel_iommu: Fix two misuse of "0x%u" prints) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201030141136.1013521-1-mst@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, 30 Oct 2020 at 14:33, <no-reply@patchew.org> wrote: > > Patchew URL: https://patchew.org/QEMU/20201030141136.1013521-1-mst@redhat.com/ I'll apply this pullreq (unless it has other more serious issues), but could you look at the coding style warnings in a followup patch, please? > 9/15 Checking commit 660b206b990b (pc: Implement -no-hpet as sugar for -machine hpet=on) > WARNING: Block comments use a leading /* on a separate line > #53: FILE: hw/i386/pc.c:1152: > + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 > > WARNING: Block comments should align the * on each line > #54: FILE: hw/i386/pc.c:1153: > + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 > + * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, > > 13/15 Checking commit e013e462e230 (vhost-blk: set features before setting inflight feature) > ERROR: trailing whitespace > #45: FILE: hw/virtio/vhost.c:1651: > + $ > > ERROR: trailing whitespace > #50: FILE: hw/virtio/vhost.c:1656: > + $ These all look like nits that should be fixed. thanks -- PMM
On Fri, 30 Oct 2020 at 14:11, Michael S. Tsirkin <mst@redhat.com> wrote: > > The following changes since commit 802427bcdae1ad2eceea8a8877ecad835e3f8fde: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201027-1' into staging (2020-10-29 11:40:04 +0000) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 73beb01ec54969f76ab32d1e0605a759b6c95ab0: > > intel_iommu: Fix two misuse of "0x%u" prints (2020-10-30 06:48:53 -0400) > > ---------------------------------------------------------------- > pc,pci,vhost,virtio: misc fixes > > Just a bunch of bugfixes all over the place. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM
On Sun, Nov 01, 2020 at 02:03:56PM +0000, Peter Maydell wrote: > On Fri, 30 Oct 2020 at 14:33, <no-reply@patchew.org> wrote: > > > > Patchew URL: https://patchew.org/QEMU/20201030141136.1013521-1-mst@redhat.com/ > > I'll apply this pullreq (unless it has other more serious > issues), but could you look at the coding style warnings in > a followup patch, please? Will do, thanks! > > > 9/15 Checking commit 660b206b990b (pc: Implement -no-hpet as sugar for -machine hpet=on) > > WARNING: Block comments use a leading /* on a separate line > > #53: FILE: hw/i386/pc.c:1152: > > + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 > > > > WARNING: Block comments should align the * on each line > > #54: FILE: hw/i386/pc.c:1153: > > + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 > > + * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, > > > > > 13/15 Checking commit e013e462e230 (vhost-blk: set features before setting inflight feature) > > ERROR: trailing whitespace > > #45: FILE: hw/virtio/vhost.c:1651: > > + $ > > > > ERROR: trailing whitespace > > #50: FILE: hw/virtio/vhost.c:1656: > > + $ > > These all look like nits that should be fixed. > > thanks > -- PMM
The following changes since commit 802427bcdae1ad2eceea8a8877ecad835e3f8fde: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20201027-1' into staging (2020-10-29 11:40:04 +0000) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 73beb01ec54969f76ab32d1e0605a759b6c95ab0: intel_iommu: Fix two misuse of "0x%u" prints (2020-10-30 06:48:53 -0400) ---------------------------------------------------------------- pc,pci,vhost,virtio: misc fixes Just a bunch of bugfixes all over the place. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Ben Widawsky (4): acpi/crs: Prevent bad ranges for host bridges acpi/crs: Support ranges > 32b for hosts pci: Change error_report to assert(3) pci: Disallow improper BAR registration for type 1 Eduardo Habkost (1): pc: Implement -no-hpet as sugar for -machine hpet=on Felipe Franciosi (1): virtio: skip guest index check on device load Greg Kurz (1): vhost: Don't special case vq->used_phys in vhost_get_log_size() Jason Wang (1): pci: advertise a page aligned ATS Jin Yu (1): vhost-blk: set features before setting inflight feature Mark Cave-Ayland (1): pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level Peter Xu (1): intel_iommu: Fix two misuse of "0x%u" prints Philippe Mathieu-Daudé (2): hw/virtio/vhost-vdpa: Fix Coverity CID 1432864 hw/pci: Extract pci_bus_change_irq_level() from pci_change_irq_level() Si-Wei Liu (1): vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver Stefano Garzarella (1): vhost-vsock: set vhostfd to non-blocking mode include/hw/i386/pc.h | 1 + include/hw/i386/x86.h | 3 --- include/hw/virtio/vhost.h | 1 + hw/block/vhost-user-blk.c | 6 +++++ hw/i386/acpi-build.c | 12 +++++++-- hw/i386/intel_iommu.c | 4 +-- hw/i386/pc.c | 63 ++++++++++++++++++++++++++++++++--------------- hw/i386/pc_piix.c | 2 +- hw/pci/pci.c | 23 +++++++++++------ hw/pci/pcie.c | 5 ++-- hw/virtio/vhost-vdpa.c | 4 +-- hw/virtio/vhost-vsock.c | 10 ++++++++ hw/virtio/vhost.c | 28 +++++++++++++-------- hw/virtio/virtio.c | 13 +++++----- net/vhost-vdpa.c | 1 + softmmu/vl.c | 4 +-- 16 files changed, 123 insertions(+), 57 deletions(-)