| Message ID | 20201030004046.2191790-8-kuhn.chenqun@huawei.com |
|---|---|
| State | Accepted |
| Commit | b2bd5b20fd1854cdbfee87553855163081a6c531 |
| Headers | show |
| Series | None | expand |
On 30/10/2020 01.40, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: > hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > 118 | if (level) { > | ^ > hw/ppc/ppc.c:123:9: note: here > 123 | case PPC6xx_INPUT_INT: > | ^~~~ > > According to the discussion, a break statement needs to be added here. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > v1->v2: Add a "break" statement here instead of /* fall through */ comments > (Base on Thomas's and David review). > > Cc: Thomas Huth <thuth@redhat.com> > Cc: David Gibson <david@gibson.dropbear.id.au> > --- > hw/ppc/ppc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c > index 4a11fb1640..1b98272076 100644 > --- a/hw/ppc/ppc.c > +++ b/hw/ppc/ppc.c > @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) > } else { > cpu_ppc_tb_stop(env); > } > + break; > case PPC6xx_INPUT_INT: > /* Level sensitive - active high */ > LOG_IRQ("%s: set the external IRQ state to %d\n", > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Fri, Oct 30, 2020 at 08:40:45AM +0800, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: > hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > 118 | if (level) { > | ^ > hw/ppc/ppc.c:123:9: note: here > 123 | case PPC6xx_INPUT_INT: > | ^~~~ > > According to the discussion, a break statement needs to be added here. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > v1->v2: Add a "break" statement here instead of /* fall through */ comments > (Base on Thomas's and David review). > > Cc: Thomas Huth <thuth@redhat.com> > Cc: David Gibson <david@gibson.dropbear.id.au> Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > hw/ppc/ppc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c > index 4a11fb1640..1b98272076 100644 > --- a/hw/ppc/ppc.c > +++ b/hw/ppc/ppc.c > @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) > } else { > cpu_ppc_tb_stop(env); > } > + break; > case PPC6xx_INPUT_INT: > /* Level sensitive - active high */ > LOG_IRQ("%s: set the external IRQ state to %d\n", -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640..1b98272076 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int level) } else { cpu_ppc_tb_stop(env); } + break; case PPC6xx_INPUT_INT: /* Level sensitive - active high */ LOG_IRQ("%s: set the external IRQ state to %d\n",
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’: hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-fallthrough=] 118 | if (level) { | ^ hw/ppc/ppc.c:123:9: note: here 123 | case PPC6xx_INPUT_INT: | ^~~~ According to the discussion, a break statement needs to be added here. Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> --- v1->v2: Add a "break" statement here instead of /* fall through */ comments (Base on Thomas's and David review). Cc: Thomas Huth <thuth@redhat.com> Cc: David Gibson <david@gibson.dropbear.id.au> --- hw/ppc/ppc.c | 1 + 1 file changed, 1 insertion(+)