| Message ID | 5A8792F8-6CB3-4161-9EBE-5DD204A4B794@msweet.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | USB printer gadget (usb_f_printer) to use default q_len value | expand |
On 20-10-29 09:54:05, Michael Sweet wrote: > Hi, > > I've been doing some work on Linux-based printer firmware lately (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.msweet.org%2Fpappl&data=04%7C01%7Cpeter.chen%40nxp.com%7C4de2e2c683e24d14316908d87c132af4%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637395769063475191%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=K5bQiNEcMDJ0dCNNvsmG%2B3Hs0KfeBc1wS9rQoxe4R4g%3D&reserved=0) and part of that includes support for USB printer gadgets - right now the legacy printer class 1/2 stuff, but soon class 4 IPP-USB. Since I also want to support functions other than printing (serial for debugging, mass storage for access to SD cards, etc.) I've been working to configure the printer gadget using configfs. After spending a few days puzzling over why the legacy g_printer gadget worked but usb_f_printer didn't I discovered that the default q_len value for the new driver is *0*, which prevents any IO from occurring! Moreover, once you've configured things and assigned the UDC it is basically impossible to change q_len, so if your Linux distro of choice does any "helpful" initialization for you then you are out of luck... > > The following patch uses a default q_len value of 10 (which is what the legacy g_printer driver uses) to minimize the possibility that you end up with a non-working printer gadget. > > > diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c > index 9c7ed2539ff7..4f3161005e4f 100644 > --- a/drivers/usb/gadget/function/f_printer.c > +++ b/drivers/usb/gadget/function/f_printer.c > @@ -50,6 +50,8 @@ > #define GET_PORT_STATUS 1 > #define SOFT_RESET 2 > > +#define DEFAULT_Q_LEN 10 /* same as legacy g_printer gadget */ > + > static int major, minors; > static struct class *usb_gadget_class; > static DEFINE_IDA(printer_ida); > @@ -1317,6 +1319,9 @@ static struct usb_function_instance *gprinter_alloc_inst(void) > opts->func_inst.free_func_inst = gprinter_free_inst; > ret = &opts->func_inst; > > + /* Make sure q_len is initialized, otherwise the bound device can't support read/write! */ > + opts->q_len = DEFAULT_Q_LEN; > + > mutex_lock(&printer_ida_lock); > > if (ida_is_empty(&printer_ida)) { This change is ok, You may generate a formal patch, and send it out. -- Thanks, Peter Chen
diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c index 9c7ed2539ff7..4f3161005e4f 100644 --- a/drivers/usb/gadget/function/f_printer.c +++ b/drivers/usb/gadget/function/f_printer.c @@ -50,6 +50,8 @@ #define GET_PORT_STATUS 1 #define SOFT_RESET 2 +#define DEFAULT_Q_LEN 10 /* same as legacy g_printer gadget */ + static int major, minors; static struct class *usb_gadget_class; static DEFINE_IDA(printer_ida); @@ -1317,6 +1319,9 @@ static struct usb_function_instance *gprinter_alloc_inst(void) opts->func_inst.free_func_inst = gprinter_free_inst; ret = &opts->func_inst; + /* Make sure q_len is initialized, otherwise the bound device can't support read/write! */ + opts->q_len = DEFAULT_Q_LEN; + mutex_lock(&printer_ida_lock); if (ida_is_empty(&printer_ida)) {