diff mbox series

[1/2] plugins: Fix resource leak in connect_socket()

Message ID 5F9975E7.6030509@huawei.com
State Superseded
Headers show
Series [1/2] plugins: Fix resource leak in connect_socket() | expand

Commit Message

Alex Chen Oct. 28, 2020, 1:45 p.m. UTC 
Close the fd when connect() fails.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: AlexChen <alex.chen@huawei.com>
---
 contrib/plugins/lockstep.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Chen Nov. 5, 2020, 6:53 a.m. UTC | #1 
Kindly ping.

On 2020/10/28 21:45, AlexChen wrote:
> Close the fd when connect() fails.
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
>  contrib/plugins/lockstep.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
> index a696673dff..319bd44b83 100644
> --- a/contrib/plugins/lockstep.c
> +++ b/contrib/plugins/lockstep.c
> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
> 
>      if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
>          perror("failed to connect");
> +        close(fd);
>          return false;
>      }
>
Alex Bennée Nov. 5, 2020, 10:37 a.m. UTC | #2 
AlexChen <alex.chen@huawei.com> writes:

> Kindly ping.

Ahh sorry I missed these. Was there a cover letter for the series?

>
> On 2020/10/28 21:45, AlexChen wrote:
>> Close the fd when connect() fails.
>> 
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: AlexChen <alex.chen@huawei.com>
>> ---
>>  contrib/plugins/lockstep.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
>> index a696673dff..319bd44b83 100644
>> --- a/contrib/plugins/lockstep.c
>> +++ b/contrib/plugins/lockstep.c
>> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>> 
>>      if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
>>          perror("failed to connect");
>> +        close(fd);
>>          return false;
>>      }
>>
Alex Chen Nov. 6, 2020, 1:40 a.m. UTC | #3 
On 2020/11/5 18:37, Alex Bennée wrote:
> 
> AlexChen <alex.chen@huawei.com> writes:
> 
>> Kindly ping.
> 
> Ahh sorry I missed these. Was there a cover letter for the series?
> 

I forgot to send the cover letter, I will send the patch V2 with the cover letter.

Thanks,
Alex Chen
diff mbox series

Patch

diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index a696673dff..319bd44b83 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -292,6 +292,7 @@  static bool connect_socket(const char *path)

     if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
         perror("failed to connect");
+        close(fd);
         return false;
     }