| Message ID | 20201028235113.660272-1-lzye@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE | expand |
On Wed, Oct 28, 2020 at 04:51:13PM -0700, FirstName LastName wrote: > Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices > need to be set explicitly with this flag. > > Signed-off-by: Chris Ye <lzye@google.com> Your email client needs to be fixed, as your "name" up there is very odd :)
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Oct 29, 2020 at 08:23:57AM -0700, Chris Ye wrote: > Haha, thanks! > I have fixed my git config and sent a new mail, can you check it? Do you have a pointer to it on lore.kernel.org? And you did properly version the patch, right? thanks, greg k-h
Hi Greg, Yes, I can see them on https://lore.kernel.org/linux-input/ now. But I didn't put [PATCH v1] in subject, should I sent them again with version? Thanks! On 10/29/20 12:14 PM, Greg KH wrote: > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Thu, Oct 29, 2020 at 08:23:57AM -0700, Chris Ye wrote: >> Haha, thanks! >> I have fixed my git config and sent a new mail, can you check it? > Do you have a pointer to it on lore.kernel.org? > > And you did properly version the patch, right? > > thanks, > > greg k-h
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Oct 29, 2020 at 01:04:06PM -0700, Chris Ye wrote: > Hi Greg, > > Yes, I can see them on https://lore.kernel.org/linux-input/ now. > > But I didn't put [PATCH v1] in subject, should I sent them again with > version? It should be v2 at the least, right? And please read the documentation for how to do that properly. thanks, greg k-h
Thanks Greg, I just sent out the v2 version of patches, to maintainers of HID core layer. On 10/30/20 3:48 AM, Greg KH wrote: > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Thu, Oct 29, 2020 at 01:04:06PM -0700, Chris Ye wrote: >> Hi Greg, >> >> Yes, I can see them on https://lore.kernel.org/linux-input/ now. >> >> But I didn't put [PATCH v1] in subject, should I sent them again with >> version? > It should be v2 at the least, right? And please read the documentation > for how to do that properly. > > thanks, > > greg k-h
diff -uprN -X linux-vanilla/Documentation/dontdiff linux-vanilla/drivers/hid/hid-ids.h linux/drivers/hid/hid-ids.h --- linux-vanilla/drivers/hid/hid-ids.h 2020-10-26 22:16:49.930361683 -0700 +++ linux/drivers/hid/hid-ids.h 2020-10-26 22:20:02.811994573 -0700 @@ -443,6 +443,10 @@ #define USB_VENDOR_ID_FRUCTEL 0x25B6 #define USB_DEVICE_ID_GAMETEL_MT_MODE 0x0002 +#define USB_VENDOR_ID_GAMEVICE 0x27F8 +#define USB_DEVICE_ID_GAMEVICE_GV186 0x0BBE +#define USB_DEVICE_ID_GAMEVICE_KISHI 0x0BBF + #define USB_VENDOR_ID_GAMERON 0x0810 #define USB_DEVICE_ID_GAMERON_DUAL_PSX_ADAPTOR 0x0001 #define USB_DEVICE_ID_GAMERON_DUAL_PCS_ADAPTOR 0x0002 diff -uprN -X linux-vanilla/Documentation/dontdiff linux-vanilla/drivers/hid/hid-quirks.c linux/drivers/hid/hid-quirks.c --- linux-vanilla/drivers/hid/hid-quirks.c 2020-10-26 22:16:49.930361683 -0700 +++ linux/drivers/hid/hid-quirks.c 2020-10-28 16:14:14.498337383 -0700 @@ -84,6 +84,10 @@ static const struct hid_device_id hid_qu { HID_USB_DEVICE(USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28), HID_QUIRK_NOGET }, { HID_USB_DEVICE(USB_VENDOR_ID_FUTABA, USB_DEVICE_ID_LED_DISPLAY), HID_QUIRK_NO_INIT_REPORTS }, { HID_USB_DEVICE(USB_VENDOR_ID_GREENASIA, USB_DEVICE_ID_GREENASIA_DUAL_USB_JOYPAD), HID_QUIRK_MULTI_INPUT }, + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_GAMEVICE, USB_DEVICE_ID_GAMEVICE_GV186), + HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE }, + { HID_USB_DEVICE(USB_VENDOR_ID_GAMEVICE, USB_DEVICE_ID_GAMEVICE_KISHI), + HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE }, { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_DRIVING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FIGHTING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_HAPP, USB_DEVICE_ID_UGCI_FLYING), HID_QUIRK_BADPAD | HID_QUIRK_MULTI_INPUT },
Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices need to be set explicitly with this flag. Signed-off-by: Chris Ye <lzye@google.com>