| Message ID | b7231b6c-97ad-5b4c-0932-08fa331dbb30@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] bsd-user: space required after semicolon | expand |
On 04/11/2020 11.20, shiliyang wrote: > This patch fixes error style problems found by checkpatch.pl: > ERROR: space required after that ';' > > Signed-off-by: Liyang Shi <shiliyang@huawei.com> > > --- > bsd-user/elfload.c | 2 +- > bsd-user/syscall.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c > index 9f4210af9a..25e625d86b 100644 > --- a/bsd-user/elfload.c > +++ b/bsd-user/elfload.c > @@ -1227,7 +1227,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct target_pt_regs *regs, > end_data = 0; > interp_ex.a_info = 0; > > - for(i=0;i < elf_ex.e_phnum; i++) { > + for(i=0; i < elf_ex.e_phnum; i++) { While you're at it, please also add white spaces around the "=" in that line. Thanks, Thomas
On 11/4/20 12:08 PM, Thomas Huth wrote: > On 04/11/2020 11.20, shiliyang wrote: >> This patch fixes error style problems found by checkpatch.pl: >> ERROR: space required after that ';' >> >> Signed-off-by: Liyang Shi <shiliyang@huawei.com> >> >> --- >> bsd-user/elfload.c | 2 +- >> bsd-user/syscall.c | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c >> index 9f4210af9a..25e625d86b 100644 >> --- a/bsd-user/elfload.c >> +++ b/bsd-user/elfload.c >> @@ -1227,7 +1227,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct target_pt_regs *regs, >> end_data = 0; >> interp_ex.a_info = 0; >> >> - for(i=0;i < elf_ex.e_phnum; i++) { >> + for(i=0; i < elf_ex.e_phnum; i++) { > > While you're at it, please also add white spaces around the "=" in that line. IOW please run checkpatch after fixing a checkpatch issue ;)
On 2020/11/4 19:13, Philippe Mathieu-Daudé wrote: > On 11/4/20 12:08 PM, Thomas Huth wrote: >> On 04/11/2020 11.20, shiliyang wrote: >>> This patch fixes error style problems found by checkpatch.pl: >>> ERROR: space required after that ';' >>> >>> Signed-off-by: Liyang Shi <shiliyang@huawei.com> >>> >>> --- >>> bsd-user/elfload.c | 2 +- >>> bsd-user/syscall.c | 4 ++-- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c >>> index 9f4210af9a..25e625d86b 100644 >>> --- a/bsd-user/elfload.c >>> +++ b/bsd-user/elfload.c >>> @@ -1227,7 +1227,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct target_pt_regs *regs, >>> end_data = 0; >>> interp_ex.a_info = 0; >>> >>> - for(i=0;i < elf_ex.e_phnum; i++) { >>> + for(i=0; i < elf_ex.e_phnum; i++) { >> >> While you're at it, please also add white spaces around the "=" in that line. > Yes, thanks for your review, I will fix it. > IOW please run checkpatch after fixing a checkpatch issue ;) > Thanks for your advise, I missed this operation. I will fix other checkpatch issues first then send new patch. > . > Thanks.
diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index 9f4210af9a..25e625d86b 100644 --- a/bsd-user/elfload.c +++ b/bsd-user/elfload.c @@ -1227,7 +1227,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct target_pt_regs *regs, end_data = 0; interp_ex.a_info = 0; - for(i=0;i < elf_ex.e_phnum; i++) { + for(i=0; i < elf_ex.e_phnum; i++) { if (elf_ppnt->p_type == PT_INTERP) { if ( elf_interpreter != NULL ) { diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 9b471b665c..b178d87de1 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@ -271,7 +271,7 @@ static abi_long lock_iovec(int type, struct iovec *vec, abi_ulong target_addr, target_vec = lock_user(VERIFY_READ, target_addr, count * sizeof(struct target_iovec), 1); if (!target_vec) return -TARGET_EFAULT; - for(i = 0;i < count; i++) { + for(i = 0; i < count; i++) { base = tswapl(target_vec[i].iov_base); vec[i].iov_len = tswapl(target_vec[i].iov_len); if (vec[i].iov_len != 0) { @@ -297,7 +297,7 @@ static abi_long unlock_iovec(struct iovec *vec, abi_ulong target_addr, target_vec = lock_user(VERIFY_READ, target_addr, count * sizeof(struct target_iovec), 1); if (!target_vec) return -TARGET_EFAULT; - for(i = 0;i < count; i++) { + for(i = 0; i < count; i++) { if (target_vec[i].iov_base) { base = tswapl(target_vec[i].iov_base); unlock_user(vec[i].iov_base, base, copy ? vec[i].iov_len : 0);
This patch fixes error style problems found by checkpatch.pl: ERROR: space required after that ';' Signed-off-by: Liyang Shi <shiliyang@huawei.com> --- bsd-user/elfload.c | 2 +- bsd-user/syscall.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)