| Message ID | 20201015181411.89104-1-ben.widawsky@intel.com |
|---|---|
| State | Accepted |
| Commit | 2c729dc8ceaab88f213c7724de0fa181ffc7f078 |
| Headers | show |
| Series | [1/2] pci: Change error_report to assert(3) | expand |
On 10/15/20 8:14 PM, Ben Widawsky wrote: > Asserts are used for developer bugs. As registering a bar of the wrong > size is not something that should be possible for a user to achieve, > this is a developer bug. > > While here, use the more obvious helper function. > > Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> > --- > hw/pci/pci.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 10/15/20 9:55 PM, Philippe Mathieu-Daudé wrote: > On 10/15/20 8:14 PM, Ben Widawsky wrote: >> Asserts are used for developer bugs. As registering a bar of the wrong >> size is not something that should be possible for a user to achieve, >> this is a developer bug. >> >> While here, use the more obvious helper function. >> >> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> >> --- >> hw/pci/pci.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Maybe 'assert(3)' -> 'assert()' in subject.
diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 100c9381c2..2c7d6dd352 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1144,11 +1144,7 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num, assert(region_num >= 0); assert(region_num < PCI_NUM_REGIONS); - if (size & (size-1)) { - error_report("ERROR: PCI region size must be pow2 " - "type=0x%x, size=0x%"FMT_PCIBUS"", type, size); - exit(1); - } + assert(is_power_of_2(size)); r = &pci_dev->io_regions[region_num]; r->addr = PCI_BAR_UNMAPPED;
Asserts are used for developer bugs. As registering a bar of the wrong size is not something that should be possible for a user to achieve, this is a developer bug. While here, use the more obvious helper function. Signed-off-by: Ben Widawsky <ben.widawsky@intel.com> --- hw/pci/pci.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)