diff mbox series

[v2,6/8] migration: Do not initialise statics and globals to 0 or NULL

Message ID 1602508140-11372-7-git-send-email-yubihong@huawei.com
State Superseded
Headers show
Series Fix some style problems in migration | expand

Commit Message

Bihong Yu Oct. 12, 2020, 1:08 p.m. UTC 
Signed-off-by: Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
---
 migration/ram.c    | 2 +-
 migration/savevm.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Dr. David Alan Gilbert Oct. 14, 2020, 7:21 p.m. UTC | #1 
* Bihong Yu (yubihong@huawei.com) wrote:
> Signed-off-by: Bihong Yu <yubihong@huawei.com>

> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>


OK, sometimes  I find initialisation clearer


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>


> ---

>  migration/ram.c    | 2 +-

>  migration/savevm.c | 2 +-

>  2 files changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/migration/ram.c b/migration/ram.c

> index 09178cc..2da2b62 100644

> --- a/migration/ram.c

> +++ b/migration/ram.c

> @@ -2743,7 +2743,7 @@ static int load_xbzrle(QEMUFile *f, ram_addr_t addr, void *host)

>   */

>  static inline RAMBlock *ram_block_from_stream(QEMUFile *f, int flags)

>  {

> -    static RAMBlock *block = NULL;

> +    static RAMBlock *block;

>      char id[256];

>      uint8_t len;

>  

> diff --git a/migration/savevm.c b/migration/savevm.c

> index 9e95df1..f808bc2 100644

> --- a/migration/savevm.c

> +++ b/migration/savevm.c

> @@ -64,7 +64,7 @@

>  #include "qemu/bitmap.h"

>  #include "net/announce.h"

>  

> -const unsigned int postcopy_ram_discard_version = 0;

> +const unsigned int postcopy_ram_discard_version;

>  

>  /* Subcommands for QEMU_VM_COMMAND */

>  enum qemu_vm_cmd {

> -- 

> 1.8.3.1

> 

-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff mbox series

Patch

diff --git a/migration/ram.c b/migration/ram.c
index 09178cc..2da2b62 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2743,7 +2743,7 @@  static int load_xbzrle(QEMUFile *f, ram_addr_t addr, void *host)
  */
 static inline RAMBlock *ram_block_from_stream(QEMUFile *f, int flags)
 {
-    static RAMBlock *block = NULL;
+    static RAMBlock *block;
     char id[256];
     uint8_t len;
 
diff --git a/migration/savevm.c b/migration/savevm.c
index 9e95df1..f808bc2 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -64,7 +64,7 @@ 
 #include "qemu/bitmap.h"
 #include "net/announce.h"
 
-const unsigned int postcopy_ram_discard_version = 0;
+const unsigned int postcopy_ram_discard_version;
 
 /* Subcommands for QEMU_VM_COMMAND */
 enum qemu_vm_cmd {