diff mbox series

[v2,1/8] migration: Do not use C99 // comments

Message ID 1602508140-11372-2-git-send-email-yubihong@huawei.com
State Superseded
Headers show
Series Fix some style problems in migration | expand

Commit Message

Bihong Yu Oct. 12, 2020, 1:08 p.m. UTC 
Signed-off-by: Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
---
 migration/block.c | 2 +-
 migration/rdma.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Dr. David Alan Gilbert Oct. 13, 2020, 9:39 a.m. UTC | #1 
* Bihong Yu (yubihong@huawei.com) wrote:
> Signed-off-by: Bihong Yu <yubihong@huawei.com>

> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>


another task at some point would be to rewrite the DPRINTF's in
migration/block.c to use trace_ instead.

> ---

>  migration/block.c | 2 +-

>  migration/rdma.c  | 2 +-

>  2 files changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/migration/block.c b/migration/block.c

> index 737b649..4b8576b 100644

> --- a/migration/block.c

> +++ b/migration/block.c

> @@ -40,7 +40,7 @@

>  #define MAX_IO_BUFFERS 512

>  #define MAX_PARALLEL_IO 16

>  

> -//#define DEBUG_BLK_MIGRATION

> +/* #define DEBUG_BLK_MIGRATION */

>  

>  #ifdef DEBUG_BLK_MIGRATION

>  #define DPRINTF(fmt, ...) \

> diff --git a/migration/rdma.c b/migration/rdma.c

> index 0340841..0eb42b7 100644

> --- a/migration/rdma.c

> +++ b/migration/rdma.c

> @@ -1288,7 +1288,7 @@ const char *print_wrid(int wrid)

>   * workload information or LRU information is available, do not attempt to use

>   * this feature except for basic testing.

>   */

> -//#define RDMA_UNREGISTRATION_EXAMPLE

> +/* #define RDMA_UNREGISTRATION_EXAMPLE */

>  

>  /*

>   * Perform a non-optimized memory unregistration after every transfer

> -- 

> 1.8.3.1

> 

-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Bihong Yu Oct. 13, 2020, 1:20 p.m. UTC | #2 
Thank you for your review. OK, I will try to rewrite the DPRINTF to use trace_ instead.

On 2020/10/13 17:39, Dr. David Alan Gilbert wrote:
> * Bihong Yu (yubihong@huawei.com) wrote:

>> Signed-off-by: Bihong Yu <yubihong@huawei.com>

>> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>

> 

> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> 

> another task at some point would be to rewrite the DPRINTF's in

> migration/block.c to use trace_ instead.

> 

>> ---

>>  migration/block.c | 2 +-

>>  migration/rdma.c  | 2 +-

>>  2 files changed, 2 insertions(+), 2 deletions(-)

>>

>> diff --git a/migration/block.c b/migration/block.c

>> index 737b649..4b8576b 100644

>> --- a/migration/block.c

>> +++ b/migration/block.c

>> @@ -40,7 +40,7 @@

>>  #define MAX_IO_BUFFERS 512

>>  #define MAX_PARALLEL_IO 16

>>  

>> -//#define DEBUG_BLK_MIGRATION

>> +/* #define DEBUG_BLK_MIGRATION */

>>  

>>  #ifdef DEBUG_BLK_MIGRATION

>>  #define DPRINTF(fmt, ...) \

>> diff --git a/migration/rdma.c b/migration/rdma.c

>> index 0340841..0eb42b7 100644

>> --- a/migration/rdma.c

>> +++ b/migration/rdma.c

>> @@ -1288,7 +1288,7 @@ const char *print_wrid(int wrid)

>>   * workload information or LRU information is available, do not attempt to use

>>   * this feature except for basic testing.

>>   */

>> -//#define RDMA_UNREGISTRATION_EXAMPLE

>> +/* #define RDMA_UNREGISTRATION_EXAMPLE */

>>  

>>  /*

>>   * Perform a non-optimized memory unregistration after every transfer

>> -- 

>> 1.8.3.1

>>
Zheng Chuan Oct. 14, 2020, 1:29 a.m. UTC | #3 
Also DEBUG_CACHE in migration/page_cache.c is need to rebase on trace_calls.

On 2020/10/13 21:20, Bihong Yu wrote:
> Thank you for your review. OK, I will try to rewrite the DPRINTF to use trace_ instead.

> 

> On 2020/10/13 17:39, Dr. David Alan Gilbert wrote:

>> * Bihong Yu (yubihong@huawei.com) wrote:

>>> Signed-off-by: Bihong Yu <yubihong@huawei.com>

>>> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>

>>

>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>>

>> another task at some point would be to rewrite the DPRINTF's in

>> migration/block.c to use trace_ instead.

>>

>>> ---

>>>  migration/block.c | 2 +-

>>>  migration/rdma.c  | 2 +-

>>>  2 files changed, 2 insertions(+), 2 deletions(-)

>>>

>>> diff --git a/migration/block.c b/migration/block.c

>>> index 737b649..4b8576b 100644

>>> --- a/migration/block.c

>>> +++ b/migration/block.c

>>> @@ -40,7 +40,7 @@

>>>  #define MAX_IO_BUFFERS 512

>>>  #define MAX_PARALLEL_IO 16

>>>  

>>> -//#define DEBUG_BLK_MIGRATION

>>> +/* #define DEBUG_BLK_MIGRATION */

>>>  

>>>  #ifdef DEBUG_BLK_MIGRATION

>>>  #define DPRINTF(fmt, ...) \

>>> diff --git a/migration/rdma.c b/migration/rdma.c

>>> index 0340841..0eb42b7 100644

>>> --- a/migration/rdma.c

>>> +++ b/migration/rdma.c

>>> @@ -1288,7 +1288,7 @@ const char *print_wrid(int wrid)

>>>   * workload information or LRU information is available, do not attempt to use

>>>   * this feature except for basic testing.

>>>   */

>>> -//#define RDMA_UNREGISTRATION_EXAMPLE

>>> +/* #define RDMA_UNREGISTRATION_EXAMPLE */

>>>  

>>>  /*

>>>   * Perform a non-optimized memory unregistration after every transfer

>>> -- 

>>> 1.8.3.1

>>>

> .

> 


-- 
Thanks, Chuan
Bihong Yu Oct. 14, 2020, 1:36 a.m. UTC | #4 
OK, I will modify it later.

On 2020/10/14 9:29, Zheng Chuan wrote:
> Also DEBUG_CACHE in migration/page_cache.c is need to rebase on trace_calls.

> 

> On 2020/10/13 21:20, Bihong Yu wrote:

>> Thank you for your review. OK, I will try to rewrite the DPRINTF to use trace_ instead.

>>

>> On 2020/10/13 17:39, Dr. David Alan Gilbert wrote:

>>> * Bihong Yu (yubihong@huawei.com) wrote:

>>>> Signed-off-by: Bihong Yu <yubihong@huawei.com>

>>>> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>

>>>

>>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>>>

>>> another task at some point would be to rewrite the DPRINTF's in

>>> migration/block.c to use trace_ instead.

>>>

>>>> ---

>>>>  migration/block.c | 2 +-

>>>>  migration/rdma.c  | 2 +-

>>>>  2 files changed, 2 insertions(+), 2 deletions(-)

>>>>

>>>> diff --git a/migration/block.c b/migration/block.c

>>>> index 737b649..4b8576b 100644

>>>> --- a/migration/block.c

>>>> +++ b/migration/block.c

>>>> @@ -40,7 +40,7 @@

>>>>  #define MAX_IO_BUFFERS 512

>>>>  #define MAX_PARALLEL_IO 16

>>>>  

>>>> -//#define DEBUG_BLK_MIGRATION

>>>> +/* #define DEBUG_BLK_MIGRATION */

>>>>  

>>>>  #ifdef DEBUG_BLK_MIGRATION

>>>>  #define DPRINTF(fmt, ...) \

>>>> diff --git a/migration/rdma.c b/migration/rdma.c

>>>> index 0340841..0eb42b7 100644

>>>> --- a/migration/rdma.c

>>>> +++ b/migration/rdma.c

>>>> @@ -1288,7 +1288,7 @@ const char *print_wrid(int wrid)

>>>>   * workload information or LRU information is available, do not attempt to use

>>>>   * this feature except for basic testing.

>>>>   */

>>>> -//#define RDMA_UNREGISTRATION_EXAMPLE

>>>> +/* #define RDMA_UNREGISTRATION_EXAMPLE */

>>>>  

>>>>  /*

>>>>   * Perform a non-optimized memory unregistration after every transfer

>>>> -- 

>>>> 1.8.3.1

>>>>

>> .

>>

>
diff mbox series

Patch

diff --git a/migration/block.c b/migration/block.c
index 737b649..4b8576b 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -40,7 +40,7 @@ 
 #define MAX_IO_BUFFERS 512
 #define MAX_PARALLEL_IO 16
 
-//#define DEBUG_BLK_MIGRATION
+/* #define DEBUG_BLK_MIGRATION */
 
 #ifdef DEBUG_BLK_MIGRATION
 #define DPRINTF(fmt, ...) \
diff --git a/migration/rdma.c b/migration/rdma.c
index 0340841..0eb42b7 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1288,7 +1288,7 @@  const char *print_wrid(int wrid)
  * workload information or LRU information is available, do not attempt to use
  * this feature except for basic testing.
  */
-//#define RDMA_UNREGISTRATION_EXAMPLE
+/* #define RDMA_UNREGISTRATION_EXAMPLE */
 
 /*
  * Perform a non-optimized memory unregistration after every transfer