| Message ID | 1602413863-19513-1-git-send-email-yubihong@huawei.com |
|---|---|
| Headers | show |
| Series | Fix some style problems in migration | expand |
Patchew URL: https://patchew.org/QEMU/1602413863-19513-1-git-send-email-yubihong@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1602413863-19513-1-git-send-email-yubihong@huawei.com
Subject: [PATCH v1 0/8] Fix some style problems in migration
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1602411429-12043-1-git-send-email-yubihong@huawei.com -> patchew/1602411429-12043-1-git-send-email-yubihong@huawei.com
- [tag update] patchew/1602413321-22252-1-git-send-email-yubihong@huawei.com -> patchew/1602413321-22252-1-git-send-email-yubihong@huawei.com
* [new tag] patchew/1602413863-19513-1-git-send-email-yubihong@huawei.com -> patchew/1602413863-19513-1-git-send-email-yubihong@huawei.com
Switched to a new branch 'test'
e540883 migration: Delete redundant spaces
ba991ab migration: Open brace '{' following function declarations go on the next line
33cc992 migration: Do not initialise statics and globals to 0 or NULL
ca4a625 migration: Add braces {} for if statement
4f4c641 migration: Open brace '{' following struct go on the same line
abbc199 migration: Add spaces around operator
3395e18 migration: Don't use '#' flag of printf format
528909a migration: Do not use C99 // comments
=== OUTPUT BEGIN ===
1/8 Checking commit 528909ad70b3 (migration: Do not use C99 // comments)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 16 lines checked
Patch 1/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/8 Checking commit 3395e181c39f (migration: Don't use '#' flag of printf format)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 24 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit abbc1992ac91 (migration: Add spaces around operator)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 59 lines checked
Patch 3/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/8 Checking commit 4f4c64176326 (migration: Open brace '{' following struct go on the same line)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 9 lines checked
Patch 4/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/8 Checking commit ca4a625ffe25 (migration: Add braces {} for if statement)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 18 lines checked
Patch 5/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/8 Checking commit 33cc992647bd (migration: Do not initialise statics and globals to 0 or NULL)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 16 lines checked
Patch 6/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/8 Checking commit ba991ab5ea63 (migration: Open brace '{' following function declarations go on the next line)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 9 lines checked
Patch 7/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/8 Checking commit e540883aba9c (migration: Delete redundant spaces)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 8 lines checked
Patch 8/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1602413863-19513-1-git-send-email-yubihong@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format migration: Add spaces around operator migration: Open brace '{' following struct go on the same line migration: Add braces {} for if statement migration: Do not initialise statics and globals to 0 or NULL migration: Open brace '{' following function declarations go on the next line migration: Delete redundant spaces migration/block.c | 4 ++-- migration/migration.c | 4 ++-- migration/migration.h | 3 +-- migration/postcopy-ram.c | 2 +- migration/ram.c | 14 ++++++++------ migration/rdma.c | 7 ++++--- migration/savevm.c | 4 ++-- migration/vmstate.c | 10 +++++----- 8 files changed, 25 insertions(+), 23 deletions(-)