Message ID | 20201028204646.356535-1-robh@kernel.org |
---|---|
Headers | show |
Series | PCI: dwc: Another round of clean-ups | expand |
On 10/28/20, 4:47 PM, Rob Herring wrote: > > Platforms using the built-in DWC MSI controller all have a dedicated > interrupt with "msi" name or at index 0, so let's move setting up the > interrupt to the common DWC code. > > spear13xx and dra7xx are the 2 oddballs with muxed interrupts, so > we need to prevent configuring the MSI interrupt by setting msi_irq > to negative. > > Cc: Jingoo Han <jingoohan1@gmail.com> Acked-by: Jingoo Han <jingoohan1@gmail.com> Best regards, Jingoo Han > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: Yue Wang <yue.wang@Amlogic.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Jesper Nilsson <jesper.nilsson@axis.com> > Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > Cc: Xiaowei Song <songxiaowei@hisilicon.com> > Cc: Binghui Wang <wangbinghui@hisilicon.com> > Cc: Stanimir Varbanov <svarbanov@mm-sol.com> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Pratyush Anand <pratyush.anand@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-kernel@axis.com > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 3 +++ > drivers/pci/controller/dwc/pci-exynos.c | 6 ----- > drivers/pci/controller/dwc/pci-imx6.c | 6 ----- > drivers/pci/controller/dwc/pci-meson.c | 6 ----- > drivers/pci/controller/dwc/pcie-artpec6.c | 6 ----- > .../pci/controller/dwc/pcie-designware-host.c | 11 +++++++++- > .../pci/controller/dwc/pcie-designware-plat.c | 6 ----- > drivers/pci/controller/dwc/pcie-histb.c | 6 ----- > drivers/pci/controller/dwc/pcie-kirin.c | 22 ------------------- > drivers/pci/controller/dwc/pcie-qcom.c | 8 ------- > drivers/pci/controller/dwc/pcie-spear13xx.c | 1 + > drivers/pci/controller/dwc/pcie-tegra194.c | 8 ------- > drivers/pci/controller/dwc/pcie-uniphier.c | 6 ----- > 13 files changed, 14 insertions(+), 81 deletions(-) [...]
On 10/28/20, 4:47 PM, Rob Herring wrote: > > All the DWC drivers do link setup and checks at roughly the same time. > Let's use the existing .start_link() hook (currently only used in EP > mode) and move the link handling to the core code. > > The behavior for a link down was inconsistent as some drivers would fail > probe in that case while others succeed. Let's standardize this to > succeed as there are usecases where devices (and the link) appear later > even without hotplug. For example, a reconfigured FPGA device. > > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Jingoo Han <jingoohan1@gmail.com> Acked-by: Jingoo Han <jingoohan1@gmail.com> Best regards, Jingoo Han > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: Murali Karicheri <m-karicheri2@ti.com> > Cc: Yue Wang <yue.wang@Amlogic.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Cc: Jesper Nilsson <jesper.nilsson@axis.com> > Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > Cc: Xiaowei Song <songxiaowei@hisilicon.com> > Cc: Binghui Wang <wangbinghui@hisilicon.com> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Stanimir Varbanov <svarbanov@mm-sol.com> > Cc: Pratyush Anand <pratyush.anand@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: linux-omap@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-kernel@axis.com > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 2 - > drivers/pci/controller/dwc/pci-exynos.c | 41 +++++++---------- > drivers/pci/controller/dwc/pci-imx6.c | 9 ++-- > drivers/pci/controller/dwc/pci-keystone.c | 9 ---- > drivers/pci/controller/dwc/pci-meson.c | 24 ++++------ > drivers/pci/controller/dwc/pcie-armada8k.c | 39 +++++++--------- > drivers/pci/controller/dwc/pcie-artpec6.c | 2 - > .../pci/controller/dwc/pcie-designware-host.c | 9 ++++ > .../pci/controller/dwc/pcie-designware-plat.c | 3 -- > drivers/pci/controller/dwc/pcie-histb.c | 34 +++++++------- > drivers/pci/controller/dwc/pcie-kirin.c | 23 ++-------- > drivers/pci/controller/dwc/pcie-qcom.c | 19 ++------ > drivers/pci/controller/dwc/pcie-spear13xx.c | 46 ++++++++----------- > drivers/pci/controller/dwc/pcie-tegra194.c | 1 - > drivers/pci/controller/dwc/pcie-uniphier.c | 13 ++---- > 15 files changed, 103 insertions(+), 171 deletions(-) [...]