diff mbox series

[v3,1/3] lib/list_kunit: Follow new file name convention for KUnit tests

Message ID 20201016110836.52613-1-andriy.shevchenko@linux.intel.com
State Superseded
Headers show
Series [v3,1/3] lib/list_kunit: Follow new file name convention for KUnit tests | expand

Commit Message

Andy Shevchenko Oct. 16, 2020, 11:08 a.m. UTC
Follow new file name convention for the KUnit tests.
Since we have lib/*test*.c in a few variations,
use 'kunit' suffix to distinguish usual test cases
with KUnit-based ones.

Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: David Gow <davidgow@google.com>
---
v3: added Rb (David), expanded Cc (Mark)
 MAINTAINERS                       | 2 +-
 lib/Makefile                      | 2 +-
 lib/{list-test.c => list_kunit.c} | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename lib/{list-test.c => list_kunit.c} (100%)

Comments

Brendan Higgins Oct. 20, 2020, 8:55 p.m. UTC | #1
On Fri, Oct 16, 2020 at 4:08 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Follow new file name convention for the KUnit tests.
> Since we have lib/*test*.c in a few variations,
> use 'kunit' suffix to distinguish usual test cases
> with KUnit-based ones.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: David Gow <davidgow@google.com>

Thanks for taking care of this!

Acked-by: Brendan Higgins <brendanhiggins@google.com>
Brendan Higgins Oct. 20, 2020, 8:55 p.m. UTC | #2
On Fri, Oct 16, 2020 at 4:08 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>

> Follow new file name convention for the KUnit tests.

> Since we have lib/*test*.c in a few variations,

> use 'kunit' suffix to distinguish usual test cases

> with KUnit-based ones.

>

> Cc: Mark Brown <broonie@kernel.org>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Reviewed-by: David Gow <davidgow@google.com>


Acked-by: Brendan Higgins <brendanhiggins@google.com>
Andy Shevchenko Oct. 30, 2020, 7:50 p.m. UTC | #3
On Fri, Oct 16, 2020 at 02:08:34PM +0300, Andy Shevchenko wrote:
> Follow new file name convention for the KUnit tests.
> Since we have lib/*test*.c in a few variations,
> use 'kunit' suffix to distinguish usual test cases
> with KUnit-based ones.

Can we get this applied?

> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: David Gow <davidgow@google.com>
> ---
> v3: added Rb (David), expanded Cc (Mark)
>  MAINTAINERS                       | 2 +-
>  lib/Makefile                      | 2 +-
>  lib/{list-test.c => list_kunit.c} | 0
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename lib/{list-test.c => list_kunit.c} (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4538378de6f5..20facbca9388 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10188,7 +10188,7 @@ M:	David Gow <davidgow@google.com>
>  L:	linux-kselftest@vger.kernel.org
>  L:	kunit-dev@googlegroups.com
>  S:	Maintained
> -F:	lib/list-test.c
> +F:	lib/list_kunit.c
>  
>  LIVE PATCHING
>  M:	Josh Poimboeuf <jpoimboe@redhat.com>
> diff --git a/lib/Makefile b/lib/Makefile
> index 5ca03ba6ee45..1a5e6a6ebe8d 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
>  
>  # KUnit tests
>  obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
> -obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> +obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
>  obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
>  obj-$(CONFIG_BITS_TEST) += test_bits.o
> diff --git a/lib/list-test.c b/lib/list_kunit.c
> similarity index 100%
> rename from lib/list-test.c
> rename to lib/list_kunit.c
> -- 
> 2.28.0
>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 4538378de6f5..20facbca9388 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10188,7 +10188,7 @@  M:	David Gow <davidgow@google.com>
 L:	linux-kselftest@vger.kernel.org
 L:	kunit-dev@googlegroups.com
 S:	Maintained
-F:	lib/list-test.c
+F:	lib/list_kunit.c
 
 LIVE PATCHING
 M:	Josh Poimboeuf <jpoimboe@redhat.com>
diff --git a/lib/Makefile b/lib/Makefile
index 5ca03ba6ee45..1a5e6a6ebe8d 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -350,6 +350,6 @@  obj-$(CONFIG_PLDMFW) += pldmfw/
 
 # KUnit tests
 obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
-obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
+obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
 obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
 obj-$(CONFIG_BITS_TEST) += test_bits.o
diff --git a/lib/list-test.c b/lib/list_kunit.c
similarity index 100%
rename from lib/list-test.c
rename to lib/list_kunit.c