diff mbox series

arm64: dts: mt8173-elm: Remove ddc property from panel

Message ID 20200826090218.682931-1-enric.balletbo@collabora.com
State Accepted
Commit f74cdb1c4e9b25e3e06f8d354371d53b97ae8482
Headers show
Series arm64: dts: mt8173-elm: Remove ddc property from panel | expand

Commit Message

Enric Balletbo i Serra Aug. 26, 2020, 9:02 a.m. UTC
The elm and hana devices uses an Embedded DisplayPort (eDP) as interface
for its panel, so the DDC channel specified in the binding is useless.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Enric Balletbo i Serra Sept. 15, 2020, 12:41 p.m. UTC | #1
Hi Matthias,

On 26/8/20 11:02, Enric Balletbo i Serra wrote:
> The elm and hana devices uses an Embedded DisplayPort (eDP) as interface

> for its panel, so the DDC channel specified in the binding is useless.

> 

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>


A gentle ping on this patch.

Thanks,
  Enric

> ---

> 

>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

> index a5a12b2599a4..1fe5dac24ba1 100644

> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

> @@ -86,7 +86,6 @@ volume_up {

>  	panel: panel {

>  		compatible = "lg,lp120up1";

>  		power-supply = <&panel_fixed_3v3>;

> -		ddc-i2c-bus = <&i2c0>;

>  		backlight = <&backlight>;

>  

>  		port {

>
Bilal Wasim Sept. 25, 2020, 11:27 p.m. UTC | #2
On Wed, 26 Aug 2020 11:02:17 +0200
Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote:

> The elm and hana devices uses an Embedded DisplayPort (eDP) as

> interface for its panel, so the DDC channel specified in the binding

> is useless.

> 

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---

> 

>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

> b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index

> a5a12b2599a4..1fe5dac24ba1 100644 ---

> a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++

> b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -86,7 +86,6 @@

> volume_up { panel: panel {

>  		compatible = "lg,lp120up1";

>  		power-supply = <&panel_fixed_3v3>;

> -		ddc-i2c-bus = <&i2c0>;

>  		backlight = <&backlight>;

>  

>  		port {


Tested-by: Bilal Wasim <bilal.wasim@imgtec.com>


Thanks,
Bilal
Matthias Brugger Oct. 1, 2020, 3:06 p.m. UTC | #3
On 26/08/2020 11:02, Enric Balletbo i Serra wrote:
> The elm and hana devices uses an Embedded DisplayPort (eDP) as interface

> for its panel, so the DDC channel specified in the binding is useless.

> 

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---


Applied to v5.10-tmp/dts64 which will be rebased on v5.10-rc1 and called 
v5.10-next/dts64

Thanks,
Matthias

> 

>   arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 -

>   1 file changed, 1 deletion(-)

> 

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

> index a5a12b2599a4..1fe5dac24ba1 100644

> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

> @@ -86,7 +86,6 @@ volume_up {

>   	panel: panel {

>   		compatible = "lg,lp120up1";

>   		power-supply = <&panel_fixed_3v3>;

> -		ddc-i2c-bus = <&i2c0>;

>   		backlight = <&backlight>;

>   

>   		port {

>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index a5a12b2599a4..1fe5dac24ba1 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -86,7 +86,6 @@  volume_up {
 	panel: panel {
 		compatible = "lg,lp120up1";
 		power-supply = <&panel_fixed_3v3>;
-		ddc-i2c-bus = <&i2c0>;
 		backlight = <&backlight>;
 
 		port {