diff mbox series

[v2] pinctrl: single: fix debug output when #pinctrl-cells = 2

Message ID 20200913230306.2061645-1-drew@beagleboard.org
State Superseded
Headers show
Series [v2] pinctrl: single: fix debug output when #pinctrl-cells = 2 | expand

Commit Message

Drew Fustini Sept. 13, 2020, 11:03 p.m. UTC
The debug output in pcs_parse_one_pinctrl_entry() needs to be updated
to print the correct pinctrl register value when #pinctrl-cells is 2.

Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
Reported-by: Trent Piepho <tpiepho@gmail.com>
Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
v2 change:
this is a fix to my prior email where I referred to #pinctrl-cells = 3
which is incorrect.  pinctrl_spec.args_count is 3 but #pinctrl-cells = 2
https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/

 drivers/pinctrl/pinctrl-single.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tony Lindgren Sept. 23, 2020, 6:55 a.m. UTC | #1
* Drew Fustini <drew@beagleboard.org> [200913 23:04]:
> The debug output in pcs_parse_one_pinctrl_entry() needs to be updated

> to print the correct pinctrl register value when #pinctrl-cells is 2.

> 

> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")

> Reported-by: Trent Piepho <tpiepho@gmail.com>

> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/

> Signed-off-by: Drew Fustini <drew@beagleboard.org>

> ---

> v2 change:

> this is a fix to my prior email where I referred to #pinctrl-cells = 3

> which is incorrect.  pinctrl_spec.args_count is 3 but #pinctrl-cells = 2

> https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/


Acked-by: Tony Lindgren <tony@atomide.com>


>  drivers/pinctrl/pinctrl-single.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c

> index 5cbf0e55087c..f3cd7e296712 100644

> --- a/drivers/pinctrl/pinctrl-single.c

> +++ b/drivers/pinctrl/pinctrl-single.c

> @@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,

>  		}

>  

>  		dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n",

> -			pinctrl_spec.np, offset, pinctrl_spec.args[1]);

> +			pinctrl_spec.np, offset, vals[found].val);

>  

>  		pin = pcs_get_pin_by_offset(pcs, offset);

>  		if (pin < 0) {

> -- 

> 2.25.1

>
Linus Walleij Oct. 1, 2020, 8:05 a.m. UTC | #2
On Mon, Sep 14, 2020 at 1:04 AM Drew Fustini <drew@beagleboard.org> wrote:

> The debug output in pcs_parse_one_pinctrl_entry() needs to be updated

> to print the correct pinctrl register value when #pinctrl-cells is 2.

>

> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")

> Reported-by: Trent Piepho <tpiepho@gmail.com>

> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/

> Signed-off-by: Drew Fustini <drew@beagleboard.org>

> ---

> v2 change:

> this is a fix to my prior email where I referred to #pinctrl-cells = 3

> which is incorrect.  pinctrl_spec.args_count is 3 but #pinctrl-cells = 2

> https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/


Patch applied!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 5cbf0e55087c..f3cd7e296712 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1033,7 +1033,7 @@  static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs,
 		}
 
 		dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n",
-			pinctrl_spec.np, offset, pinctrl_spec.args[1]);
+			pinctrl_spec.np, offset, vals[found].val);
 
 		pin = pcs_get_pin_by_offset(pcs, offset);
 		if (pin < 0) {