diff mbox series

[-next,v2] crypto: amlogic: Convert to DEFINE_SHOW_ATTRIBUTE

Message ID 20200918013110.82604-1-miaoqinglang@huawei.com
State Accepted
Commit b11d90639aa7d37a7133887db76b7fd697072343
Headers show
Series [-next,v2] crypto: amlogic: Convert to DEFINE_SHOW_ATTRIBUTE | expand

Commit Message

'Qinglang Miao Sept. 18, 2020, 1:31 a.m. UTC
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
v2: based on linux-next(20200917), and can be applied to
    mainline cleanly now.

 drivers/crypto/amlogic/amlogic-gxl-core.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

Comments

Herbert Xu Sept. 25, 2020, 8:15 a.m. UTC | #1
On Fri, Sep 18, 2020 at 09:31:10AM +0800, Qinglang Miao wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

> 

> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>

> ---

> v2: based on linux-next(20200917), and can be applied to

>     mainline cleanly now.

> 

>  drivers/crypto/amlogic/amlogic-gxl-core.c | 16 ++--------------

>  1 file changed, 2 insertions(+), 14 deletions(-)


Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff mbox series

Patch

diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 466552acb..5bbeff433 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -98,7 +98,7 @@  static struct meson_alg_template mc_algs[] = {
 };
 
 #ifdef CONFIG_CRYPTO_DEV_AMLOGIC_GXL_DEBUG
-static int meson_dbgfs_read(struct seq_file *seq, void *v)
+static int meson_debugfs_show(struct seq_file *seq, void *v)
 {
 	struct meson_dev *mc = seq->private;
 	int i;
@@ -118,19 +118,7 @@  static int meson_dbgfs_read(struct seq_file *seq, void *v)
 	}
 	return 0;
 }
-
-static int meson_dbgfs_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, meson_dbgfs_read, inode->i_private);
-}
-
-static const struct file_operations meson_debugfs_fops = {
-	.owner = THIS_MODULE,
-	.open = meson_dbgfs_open,
-	.read = seq_read,
-	.llseek = seq_lseek,
-	.release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(meson_debugfs);
 #endif
 
 static void meson_free_chanlist(struct meson_dev *mc, int i)