| Message ID | 20200917151050.5363-13-willy@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | Allow readpage to return a locked page | expand |
On Thu 17-09-20 16:10:49, Matthew Wilcox (Oracle) wrote: > The udf inline data readpage implementation was already synchronous, > so use AOP_UPDATED_PAGE to avoid cycling the page lock. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/udf/file.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/udf/file.c b/fs/udf/file.c > index 628941a6b79a..52bbe92d7c43 100644 > --- a/fs/udf/file.c > +++ b/fs/udf/file.c > @@ -61,9 +61,8 @@ static int udf_adinicb_readpage(struct file *file, struct page *page) > { > BUG_ON(!PageLocked(page)); > __udf_adinicb_readpage(page); > - unlock_page(page); > > - return 0; > + return AOP_UPDATED_PAGE; > } > > static int udf_adinicb_writepage(struct page *page, > -- > 2.28.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
diff --git a/fs/udf/file.c b/fs/udf/file.c index 628941a6b79a..52bbe92d7c43 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c @@ -61,9 +61,8 @@ static int udf_adinicb_readpage(struct file *file, struct page *page) { BUG_ON(!PageLocked(page)); __udf_adinicb_readpage(page); - unlock_page(page); - return 0; + return AOP_UPDATED_PAGE; } static int udf_adinicb_writepage(struct page *page,
The udf inline data readpage implementation was already synchronous, so use AOP_UPDATED_PAGE to avoid cycling the page lock. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/udf/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)