| Message ID | 20200918011335.909141-1-yukuai3@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate() | expand |
Hi On 18.09.2020 03:13, Yu Kuai wrote: > if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > > Fixes: aa759fd376fb ("iommu/exynos: Add callback for initializing devices from device tree") > Signed-off-by: Yu Kuai <yukuai3@huawei.com> Thanks for the fix! Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/iommu/exynos-iommu.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index bad3c0ce10cb..de324b4eedfe 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -1295,13 +1295,17 @@ static int exynos_iommu_of_xlate(struct device *dev, > return -ENODEV; > > data = platform_get_drvdata(sysmmu); > - if (!data) > + if (!data) { > + put_device(&sysmmu->dev); > return -ENODEV; > + } > > if (!owner) { > owner = kzalloc(sizeof(*owner), GFP_KERNEL); > - if (!owner) > + if (!owner) { > + put_device(&sysmmu->dev); > return -ENOMEM; > + } > > INIT_LIST_HEAD(&owner->controllers); > mutex_init(&owner->rpm_lock); Best regards
On Fri, Sep 18, 2020 at 05:27:59PM +0200, Marek Szyprowski wrote: > Hi > > On 18.09.2020 03:13, Yu Kuai wrote: > > if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have > > a corresponding put_device(). Thus add put_device() to fix the exception > > handling for this function implementation. > > > > Fixes: aa759fd376fb ("iommu/exynos: Add callback for initializing devices from device tree") > > Signed-off-by: Yu Kuai <yukuai3@huawei.com> > > Thanks for the fix! > > Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> Applied for v5.9, thanks.
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index bad3c0ce10cb..de324b4eedfe 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1295,13 +1295,17 @@ static int exynos_iommu_of_xlate(struct device *dev, return -ENODEV; data = platform_get_drvdata(sysmmu); - if (!data) + if (!data) { + put_device(&sysmmu->dev); return -ENODEV; + } if (!owner) { owner = kzalloc(sizeof(*owner), GFP_KERNEL); - if (!owner) + if (!owner) { + put_device(&sysmmu->dev); return -ENOMEM; + } INIT_LIST_HEAD(&owner->controllers); mutex_init(&owner->rpm_lock);
if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have a corresponding put_device(). Thus add put_device() to fix the exception handling for this function implementation. Fixes: aa759fd376fb ("iommu/exynos: Add callback for initializing devices from device tree") Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- drivers/iommu/exynos-iommu.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)