[v3,0/4] Venus - change clk enable, disable order and change bw values

The intention of this patchset is to correct clock enable and disable
order and vote for venus-ebi and cpucfg paths with average bandwidth
instad of peak bandwidth since with current implementation we are seeing
clock related warning during XO-SD and suspend device while video playback

Mansur Alisha Shaik (4):
  venus: core: change clk enable and disable order in resume and suspend
  venus: core: vote for video-mem path
  venus: core: vote with average bandwidth and peak bandwidth as zero
  venus: put dummy vote on video-mem path after last session release

 drivers/media/platform/qcom/venus/core.c       | 32 ++++++++++++++++++++------
 drivers/media/platform/qcom/venus/pm_helpers.c | 10 ++++++++
 2 files changed, 35 insertions(+), 7 deletions(-)

Quoting Mansur Alisha Shaik (2020-09-23 23:51:05)
> As per bandwidth table video driver is voting with average bandwidth

> for "video-mem" and "cpu-cfg" paths as peak bandwidth is zero

> in bandwidth table.

> 

> Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")

> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>

> ---

> Changes in v3:

> - Added fixes tag

> 

>  drivers/media/platform/qcom/venus/core.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c

> index fa363b8..d5bfd6f 100644

> --- a/drivers/media/platform/qcom/venus/core.c

> +++ b/drivers/media/platform/qcom/venus/core.c

> @@ -385,11 +385,11 @@ static __maybe_unused int venus_runtime_resume(struct device *dev)

>         const struct venus_pm_ops *pm_ops = core->pm_ops;

>         int ret;

>  

> -       ret = icc_set_bw(core->video_path, 0, kbps_to_icc(1000));

> +       ret = icc_set_bw(core->video_path, kbps_to_icc(20000), 0);


This gets added in the previous patch. Why not put this patch before
that one?

Anyway..

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Quoting Mansur Alisha Shaik (2020-09-23 23:51:04)
> Currently video driver is voting for venus0-ebi path during buffer
> processing with an average bandwidth of all the instances and
> unvoting during session release.
> 
> While video streaming when we try to do XO-SD using the command
> "echo mem > /sys/power/state command" , device is not entering
> to suspend state and from interconnect summary seeing votes for venus0-ebi
> 
> Corrected this by voting for venus0-ebi path in venus_runtime_resume()
> and unvote during venus_runtime_suspend().
> 
> Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> ---
> Changes in v3:
> - Addressed review comments by Stephen Boyd

Please Cc me on patches I review.

> 
>  drivers/media/platform/qcom/venus/core.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 52a3886..fa363b8 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -363,7 +363,18 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev)
>  
>         ret = icc_set_bw(core->cpucfg_path, 0, 0);
>         if (ret)
> -               return ret;
> +               goto err_cpucfg_path;
> +
> +       ret = icc_set_bw(core->video_path, 0, 0);
> +       if (ret)
> +               goto err_video_path;
> +
> +       return ret;
> +
> +err_video_path:
> +       icc_set_bw(core->cpucfg_path, kbps_to_icc(1000), 0);
> +err_cpucfg_path:
> +       pm_ops->core_power(dev, POWER_ON);
>  
>         return ret;
>  }
> @@ -374,6 +385,10 @@ static __maybe_unused int venus_runtime_resume(struct device *dev)
>         const struct venus_pm_ops *pm_ops = core->pm_ops;
>         int ret;
>  
> +       ret = icc_set_bw(core->video_path, 0, kbps_to_icc(1000));
> +       if (ret)
> +               return ret;
> +

Feels like this patch should come after the next one but OK.

Reviewed-by: Stephen Boyd <swboyd@chromium.org>