mbox series

[0/2] zfcp: small changes for 5.10

Message ID cover.1599765652.git.bblock@linux.ibm.com
Headers show
Series zfcp: small changes for 5.10 | expand

Message

Benjamin Block Sept. 10, 2020, 7:49 p.m. UTC 
Hello Martin, James,

here are some small changes for zfcp I'd like to include in 5.10 if
possible. They apply cleanly on Martin's `scsi-queue`, and James' `misc`
branches.

Both patches make the driver a bit cleaner, and hopefully easier to
maintain.

Both have been in our CI for quite a while now, running every night. I
also gave them a separate regression run just now with I/O and
error-injects such as cable pulls and other external error sources. So I
am rather confident that they don't break anything for us - apart from
that they're straight forward code changes.

As always, feedback and further reviews are appreciated :-)

Julian Wiedmann (2):
  zfcp: use list_first_entry_or_null() in zfcp_erp_thread()
  zfcp: clarify access to erp_action in zfcp_fsf_req_complete()

 drivers/s390/scsi/zfcp_erp.c |  8 +++-----
 drivers/s390/scsi/zfcp_fsf.c | 10 ++++++++--
 2 files changed, 11 insertions(+), 7 deletions(-)

Comments

Martin K. Petersen Sept. 15, 2020, 10:03 p.m. UTC | #1 
Benjamin,

> here are some small changes for zfcp I'd like to include in 5.10 if
> possible.

Applied to 5.10/scsi-staging, thanks!
Martin K. Petersen Sept. 22, 2020, 3:56 a.m. UTC | #2 
On Thu, 10 Sep 2020 21:49:14 +0200, Benjamin Block wrote:

> here are some small changes for zfcp I'd like to include in 5.10 if

> possible. They apply cleanly on Martin's `scsi-queue`, and James' `misc`

> branches.

> 

> Both patches make the driver a bit cleaner, and hopefully easier to

> maintain.

> 

> [...]


Applied to 5.10/scsi-queue, thanks!

[1/2] scsi: zfcp: Use list_first_entry_or_null() in zfcp_erp_thread()
      https://git.kernel.org/mkp/scsi/c/addf13729615
[2/2] scsi: zfcp: Clarify access to erp_action in zfcp_fsf_req_complete()
      https://git.kernel.org/mkp/scsi/c/d251193d1732

-- 
Martin K. Petersen	Oracle Linux Engineering
Benjamin Block Sept. 22, 2020, 10:05 a.m. UTC | #3 
On Mon, Sep 21, 2020 at 11:56:45PM -0400, Martin K. Petersen wrote:
> On Thu, 10 Sep 2020 21:49:14 +0200, Benjamin Block wrote:

> 

> > here are some small changes for zfcp I'd like to include in 5.10 if

> > possible. They apply cleanly on Martin's `scsi-queue`, and James' `misc`

> > branches.

> > 

> > Both patches make the driver a bit cleaner, and hopefully easier to

> > maintain.

> > 

> > [...]

> 

> Applied to 5.10/scsi-queue, thanks!

> 

> [1/2] scsi: zfcp: Use list_first_entry_or_null() in zfcp_erp_thread()

>       https://git.kernel.org/mkp/scsi/c/addf13729615

> [2/2] scsi: zfcp: Clarify access to erp_action in zfcp_fsf_req_complete()

>       https://git.kernel.org/mkp/scsi/c/d251193d1732

> 


Thanks Martin!

-- 
Best Regards, Benjamin Block  / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH    /    https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen         /        Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294