| Message ID | 20200921070417.1121-1-hankinsea@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] powercap: include header to fix -Wmissing-prototypes | expand |
On Mon, Sep 21, 2020 at 9:04 AM Herrington <hankinsea@gmail.com> wrote: > > Include the linux/idle_inject.h header to fix W=1 build warning: > > drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes] > drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes] > > Signed-off-by: Herrington <hankinsea@gmail.com> > Signed-off-by: Pujin Shi <shipujin.t@gmail.com> > Signed-off-by: Pujin Shi <shipj@lemote.com> First, who is the other person whose S-o-b is present here? For a co-author of the patch, a Co-developed-by tag should be present too. Otherwise, a Reviewed-by tag should be used instead of the S-o-b. Also, one S-o-b (or R-by) per developer would be sufficient. > --- > drivers/powercap/idle_inject.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c > index 4310901a074e..6e1a0043c411 100644 > --- a/drivers/powercap/idle_inject.c > +++ b/drivers/powercap/idle_inject.c > @@ -43,6 +43,7 @@ > #include <linux/sched.h> > #include <linux/slab.h> > #include <linux/smpboot.h> > +#include <linux/idle_inject.h> > > #include <uapi/linux/sched/types.h> > > -- > 2.25.4 >
diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c index 4310901a074e..6e1a0043c411 100644 --- a/drivers/powercap/idle_inject.c +++ b/drivers/powercap/idle_inject.c @@ -43,6 +43,7 @@ #include <linux/sched.h> #include <linux/slab.h> #include <linux/smpboot.h> +#include <linux/idle_inject.h> #include <uapi/linux/sched/types.h>
Include the linux/idle_inject.h header to fix W=1 build warning: drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes] drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes] Signed-off-by: Herrington <hankinsea@gmail.com> Signed-off-by: Pujin Shi <shipujin.t@gmail.com> Signed-off-by: Pujin Shi <shipj@lemote.com> --- drivers/powercap/idle_inject.c | 1 + 1 file changed, 1 insertion(+)