| Message ID | 20200917131515.147029-1-jingxiangfeng@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | fbcon: Remove the superfluous break | expand |
On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote: > > Remove the superfuous break, as there is a 'return' before it. superfluous (missed "l") > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Thanks for the patch; I audited the rest of the switch statements in this translation unit; LGTM. > --- > drivers/video/fbdev/core/fbcon.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > index 0b49b0f44edf..623359aadd1e 100644 > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > vc->vc_video_erase_char, > vc->vc_size_row * count); > return true; > - break; > > case SCROLL_WRAP_MOVE: > if (b - t - count > 3 * vc->vc_rows >> 2) { > @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > vc->vc_video_erase_char, > vc->vc_size_row * count); > return true; > - break; > > case SCROLL_WRAP_MOVE: > if (b - t - count > 3 * vc->vc_rows >> 2) { > -- > 2.17.1 > -- Thanks, ~Nick Desaulniers
On 9/17/20 08:15, Jing Xiangfeng wrote: > Remove the superfuous break, as there is a 'return' before it. > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Also, the following Fixes tag should be included in the changelog text: Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling") Thanks -- Gustavo > --- > drivers/video/fbdev/core/fbcon.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > index 0b49b0f44edf..623359aadd1e 100644 > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > vc->vc_video_erase_char, > vc->vc_size_row * count); > return true; > - break; > > case SCROLL_WRAP_MOVE: > if (b - t - count > 3 * vc->vc_rows >> 2) { > @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, > vc->vc_video_erase_char, > vc->vc_size_row * count); > return true; > - break; > > case SCROLL_WRAP_MOVE: > if (b - t - count > 3 * vc->vc_rows >> 2) { >
On 2020/9/18 1:36, Nick Desaulniers wrote: > On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote: >> >> Remove the superfuous break, as there is a 'return' before it. > > superfluous (missed "l") Thanks for correcting! > >> >> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > Thanks for the patch; I audited the rest of the switch statements in > this translation unit; LGTM. > >> --- >> drivers/video/fbdev/core/fbcon.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c >> index 0b49b0f44edf..623359aadd1e 100644 >> --- a/drivers/video/fbdev/core/fbcon.c >> +++ b/drivers/video/fbdev/core/fbcon.c >> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> -- >> 2.17.1 >> > >
On 2020/9/18 2:52, Gustavo A. R. Silva wrote: > > > On 9/17/20 08:15, Jing Xiangfeng wrote: >> Remove the superfuous break, as there is a 'return' before it. >> >> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> > > Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > Also, the following Fixes tag should be included in the changelog text: > > Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling") OK, I'll send a v2 with this tag. > > Thanks > -- > Gustavo > >> --- >> drivers/video/fbdev/core/fbcon.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c >> index 0b49b0f44edf..623359aadd1e 100644 >> --- a/drivers/video/fbdev/core/fbcon.c >> +++ b/drivers/video/fbdev/core/fbcon.c >> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, >> vc->vc_video_erase_char, >> vc->vc_size_row * count); >> return true; >> - break; >> >> case SCROLL_WRAP_MOVE: >> if (b - t - count > 3 * vc->vc_rows >> 2) { >> > . >
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 0b49b0f44edf..623359aadd1e 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, vc->vc_video_erase_char, vc->vc_size_row * count); return true; - break; case SCROLL_WRAP_MOVE: if (b - t - count > 3 * vc->vc_rows >> 2) { @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b, vc->vc_video_erase_char, vc->vc_size_row * count); return true; - break; case SCROLL_WRAP_MOVE: if (b - t - count > 3 * vc->vc_rows >> 2) {
Remove the superfuous break, as there is a 'return' before it. Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> --- drivers/video/fbdev/core/fbcon.c | 2 -- 1 file changed, 2 deletions(-)