diff mbox series

spi: xilinx: Fix info message during probe

Message ID 20200915112936.320647-1-ribalda@kernel.org
State Accepted
Commit 985be7ebfbf79767bc3705eee7de635edd4eba7d
Headers show
Series spi: xilinx: Fix info message during probe | expand

Commit Message

Ricardo Ribalda Delgado Sept. 15, 2020, 11:29 a.m. UTC
The info message was showing the mapped address of the device. To avoid
security problems, all virtual addresses are converted to __ptrval__, so
the message was useless/ugly:

[    2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37

Use %pR instead:

[   15.021354] xilinx_spi b0010000.spi-flash: at [mem 0xb0010000-0xb001ffff], irq=37

Signed-off-by: Ricardo Ribalda <ribalda@kernel.org>
---
 drivers/spi/spi-xilinx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Michal Simek Sept. 15, 2020, 11:41 a.m. UTC | #1
On 15. 09. 20 13:29, Ricardo Ribalda wrote:
> The info message was showing the mapped address of the device. To avoid

> security problems, all virtual addresses are converted to __ptrval__, so

> the message was useless/ugly:

> 

> [    2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37

> 

> Use %pR instead:

> 

> [   15.021354] xilinx_spi b0010000.spi-flash: at [mem 0xb0010000-0xb001ffff], irq=37

> 

> Signed-off-by: Ricardo Ribalda <ribalda@kernel.org>

> ---

>  drivers/spi/spi-xilinx.c | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)

> 

> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c

> index 8dd2bb99cb4d..523edfdf5dcd 100644

> --- a/drivers/spi/spi-xilinx.c

> +++ b/drivers/spi/spi-xilinx.c

> @@ -491,8 +491,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)

>  		goto put_master;

>  	}

>  

> -	dev_info(&pdev->dev, "at 0x%08llX mapped to 0x%p, irq=%d\n",

> -		(unsigned long long)res->start, xspi->regs, xspi->irq);

> +	dev_info(&pdev->dev, "at %pR, irq=%d\n", res, xspi->irq);

>  

>  	if (pdata) {

>  		for (i = 0; i < pdata->num_devices; i++)

> 


Acked-by: Michal Simek <michal.simek@xilinx.com>


Thanks,
Michal
Mark Brown Sept. 17, 2020, 6:58 p.m. UTC | #2
On Tue, 15 Sep 2020 13:29:36 +0200, Ricardo Ribalda wrote:
> The info message was showing the mapped address of the device. To avoid

> security problems, all virtual addresses are converted to __ptrval__, so

> the message was useless/ugly:

> 

> [    2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37

> 

> Use %pR instead:

> 

> [...]


Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: xilinx: Fix info message during probe
      commit: 985be7ebfbf79767bc3705eee7de635edd4eba7d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index 8dd2bb99cb4d..523edfdf5dcd 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -491,8 +491,7 @@  static int xilinx_spi_probe(struct platform_device *pdev)
 		goto put_master;
 	}
 
-	dev_info(&pdev->dev, "at 0x%08llX mapped to 0x%p, irq=%d\n",
-		(unsigned long long)res->start, xspi->regs, xspi->irq);
+	dev_info(&pdev->dev, "at %pR, irq=%d\n", res, xspi->irq);
 
 	if (pdata) {
 		for (i = 0; i < pdata->num_devices; i++)