| Message ID | 5F8FFB94.3030209@huawei.com |
|---|---|
| State | Accepted |
| Commit | 3d86af858ec081b2b385b6fd5af09e42ca825a96 |
| Headers | show |
| Series | block: Remove unused include | expand |
Kindly ping. Thanks, Alex On 2020/10/21 17:12, AlexChen wrote: > The "qemu-common.h" include is not used, remove it. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: AlexChen <alex.chen@huawei.com> > --- > block/dmg-lzfse.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/dmg-lzfse.c b/block/dmg-lzfse.c > index 19d25bc646..6798cf4fbf 100644 > --- a/block/dmg-lzfse.c > +++ b/block/dmg-lzfse.c > @@ -22,7 +22,6 @@ > * THE SOFTWARE. > */ > #include "qemu/osdep.h" > -#include "qemu-common.h" > #include "dmg.h" > #include <lzfse.h> >
On 21.10.20 11:12, AlexChen wrote: > The "qemu-common.h" include is not used, remove it. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: AlexChen <alex.chen@huawei.com> > --- > block/dmg-lzfse.c | 1 - > 1 file changed, 1 deletion(-) Thanks, I’ve applied this patch to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Please note (for future patches) that all patches’ subjects should by prefixed by “[PATCH]”, as done by git format-patch (see https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch). Max
On 2020/11/3 21:26, Max Reitz wrote: > On 21.10.20 11:12, AlexChen wrote: >> The "qemu-common.h" include is not used, remove it. >> >> Reported-by: Euler Robot <euler.robot@huawei.com> >> Signed-off-by: AlexChen <alex.chen@huawei.com> >> --- >> block/dmg-lzfse.c | 1 - >> 1 file changed, 1 deletion(-) > > Thanks, I’ve applied this patch to my block branch: > > https://git.xanclic.moe/XanClic/qemu/commits/branch/block > > Please note (for future patches) that all patches’ subjects should by > prefixed by “[PATCH]”, as done by git format-patch (see > https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch). > Oh, this is my fault, I will pay attention to this in my subsequent patches. Thanks, Alex
diff --git a/block/dmg-lzfse.c b/block/dmg-lzfse.c index 19d25bc646..6798cf4fbf 100644 --- a/block/dmg-lzfse.c +++ b/block/dmg-lzfse.c @@ -22,7 +22,6 @@ * THE SOFTWARE. */ #include "qemu/osdep.h" -#include "qemu-common.h" #include "dmg.h" #include <lzfse.h>
The "qemu-common.h" include is not used, remove it. Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: AlexChen <alex.chen@huawei.com> --- block/dmg-lzfse.c | 1 - 1 file changed, 1 deletion(-)