| Message ID | 20201005203451.9985-1-post@lespocky.de |
|---|---|
| Headers | show |
| Series | leds: pwm: Make automatic labels work | expand |
On Mon, 5 Oct 2020 at 22:36, Alexander Dahl <post@lespocky.de> wrote: > > The node names for devices using the pwm-leds driver follow a certain > naming scheme (now). Parent node name is not enforced, but recommended > by DT project. > > DTC arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml > CHECK arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml > DTC arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml > CHECK arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidhc1.dt.yaml: pwmleds: 'blueled' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml > DTC arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml > CHECK arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu3.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml > DTC arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml > CHECK arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml > DTC arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml > CHECK arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/exynos5422-odroidxu4.dt.yaml: pwmleds: 'blueled' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml > > Signed-off-by: Alexander Dahl <post@lespocky.de> > --- > > Notes: > v6 -> v7: > * split up patch (one per sub arch) > * added actual warnings to commit message > > arch/arm/boot/dts/exynos5422-odroidhc1.dts | 4 ++-- > arch/arm/boot/dts/exynos5422-odroidxu4.dts | 4 ++-- > arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi | 11 ++++++----- > 3 files changed, 10 insertions(+), 9 deletions(-) Looks OK but it is too late for this cycle. I'll pick it up after merge window. Best regards, Krzysztof
On Mon, Oct 05, 2020 at 10:34:46PM +0200, Alexander Dahl wrote: > The node names for devices using the pwm-leds driver follow a certain > naming scheme (now). Parent node name is not enforced, but recommended > by DT project. > > DTC arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml > CHECK arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/exynos5410-odroidxu.dt.yaml: pwmleds: 'blueled', 'greenled' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml Please trim the error logs in the future. No need to paste all warnings, just one or two from the same type of error. Also your local path leading to Linux repo should be removed. Thanks, applied. Best regards, Krzysztof
On Mon, 5 Oct 2020 22:34:39 +0200, Alexander Dahl wrote: > Hei hei, > > for leds-gpio you can use the properties 'function' and 'color' in the > devicetree node and omit 'label', the label is constructed > automatically. This is a common feature supposed to be working for all > LED drivers. However it did not work until recently for the 'leds-pwm' > driver. > > [...] Applied, thanks! [1/2] ARM: dts: at91: smartkiz: Reference led node directly commit: 02e46262af5db410da5a27783833d68e2bdfb352 [2/2] ARM: dts: at91: Fix schema warnings for pwm-leds commit: 997ebd64df39f3916c37ca67a6eff58e79a13c73 Best regards,
On 28/10/2020 19:56:14+0100, Alexandre Belloni wrote: > On Mon, 5 Oct 2020 22:34:39 +0200, Alexander Dahl wrote: > > Hei hei, > > > > for leds-gpio you can use the properties 'function' and 'color' in the > > devicetree node and omit 'label', the label is constructed > > automatically. This is a common feature supposed to be working for all > > LED drivers. However it did not work until recently for the 'leds-pwm' > > driver. > > > > [...] > > Applied, thanks! > > [1/2] ARM: dts: at91: smartkiz: Reference led node directly > commit: 02e46262af5db410da5a27783833d68e2bdfb352 > [2/2] ARM: dts: at91: Fix schema warnings for pwm-leds > commit: 997ebd64df39f3916c37ca67a6eff58e79a13c73 This was obviously 04/12 and 05/12.