| Message ID | 20200909102640.1657622-7-warthog618@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | gpio: cdev: add uAPI v2 | expand |
On Wed, Sep 9, 2020 at 1:33 PM Kent Gibson <warthog618@gmail.com> wrote: > > Add a build option to allow the removal of the CDEV v1 ABI. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> One nit-pick below. > Suggested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > Signed-off-by: Kent Gibson <warthog618@gmail.com> > --- > > This patch is before the v2 implementation, and is non-functional until > that patch, as some parts of that patch would be written slightly > differently if removing v1 was not considered. > Adding this patch after that would necessitate revisiting the v2 changes, > so this ordering results in two simpler patches. > > drivers/gpio/Kconfig | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index e4debd66d71f..ff9ca836026b 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -82,6 +82,18 @@ config GPIO_CDEV > > If unsure, say Y. > > +config GPIO_CDEV_V1 > + bool "Support GPIO ABI Version 1" > + default y > + depends on GPIO_CDEV > + help > + Say Y here to support version 1 of the GPIO CDEV ABI. > + > + This ABI version is deprecated and will be removed in the future. > + Please use the latest ABI for new developments. "will be removed" is not what is going to happen in at least the next few years. I think something less strong would be better. > + > + If unsure, say Y. > + > config GPIO_GENERIC > depends on HAS_IOMEM # Only for IOMEM drivers > tristate > -- > 2.28.0 > -- With Best Regards, Andy Shevchenko
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index e4debd66d71f..ff9ca836026b 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -82,6 +82,18 @@ config GPIO_CDEV If unsure, say Y. +config GPIO_CDEV_V1 + bool "Support GPIO ABI Version 1" + default y + depends on GPIO_CDEV + help + Say Y here to support version 1 of the GPIO CDEV ABI. + + This ABI version is deprecated and will be removed in the future. + Please use the latest ABI for new developments. + + If unsure, say Y. + config GPIO_GENERIC depends on HAS_IOMEM # Only for IOMEM drivers tristate
Add a build option to allow the removal of the CDEV v1 ABI. Suggested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Signed-off-by: Kent Gibson <warthog618@gmail.com> --- This patch is before the v2 implementation, and is non-functional until that patch, as some parts of that patch would be written slightly differently if removing v1 was not considered. Adding this patch after that would necessitate revisiting the v2 changes, so this ordering results in two simpler patches. drivers/gpio/Kconfig | 12 ++++++++++++ 1 file changed, 12 insertions(+)