| Message ID | 20201006153636.2383248-1-philmd@redhat.com |
|---|---|
| Headers | show |
| Series | qom: Fix missing interface in qemu-storage-daemon | expand |
Patchew URL: https://patchew.org/QEMU/20201006153636.2383248-1-philmd@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201006153636.2383248-1-philmd@redhat.com
Subject: [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/20201006153636.2383248-1-philmd@redhat.com -> patchew/20201006153636.2383248-1-philmd@redhat.com
fatal: failed to write ref-pack file
fatal: The remote end hung up unexpectedly
Traceback (most recent call last):
File "patchew-tester2/src/patchew-cli", line 531, in test_one
git_clone_repo(clone, r["repo"], r["head"], logf, True)
File "patchew-tester2/src/patchew-cli", line 62, in git_clone_repo
subprocess.check_call(clone_cmd, stderr=logf, stdout=logf)
File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'clone', '-q', '/home/patchew2/.cache/patchew-git-cache/httpsgithubcompatchewprojectqemu-3c8cf5a9c21ff8782164d1def7f44bd888713384', '/var/tmp/patchew-tester-tmp-ttyqifjv/src']' returned non-zero exit status 128.
The full log is available at
http://patchew.org/logs/20201006153636.2383248-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On 10/6/20 5:51 PM, Richard Henderson wrote: > On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >> +++ b/hw/nvram/fw_cfg-interface.c >> @@ -0,0 +1,15 @@ >> +#include "qemu/osdep.h" >> +#include "hw/nvram/fw_cfg.h" > > License boilerplate missing. Grr. Paolo since you queued this, do you mind fixing directly?
On 10/06/20 17:51, Richard Henderson wrote: > On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >> +++ b/hw/nvram/fw_cfg-interface.c >> @@ -0,0 +1,15 @@ >> +#include "qemu/osdep.h" >> +#include "hw/nvram/fw_cfg.h" > > License boilerplate missing. > > r~ > Hrmpf, so easy to forget about that, especially in review :/ Thanks for catching it. Laszlo
On 10/6/20 6:04 PM, Laszlo Ersek wrote: > On 10/06/20 17:51, Richard Henderson wrote: >> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >>> +++ b/hw/nvram/fw_cfg-interface.c >>> @@ -0,0 +1,15 @@ >>> +#include "qemu/osdep.h" >>> +#include "hw/nvram/fw_cfg.h" >> >> License boilerplate missing. >> >> r~ >> > > Hrmpf, so easy to forget about that, especially in review :/ Although easily scriptable if we consider SPDX identifiers... > Thanks for > catching it. > > Laszlo >
On 06/10/20 18:02, Philippe Mathieu-Daudé wrote: > On 10/6/20 5:51 PM, Richard Henderson wrote: >> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >>> +++ b/hw/nvram/fw_cfg-interface.c >>> @@ -0,0 +1,15 @@ >>> +#include "qemu/osdep.h" >>> +#include "hw/nvram/fw_cfg.h" >> >> License boilerplate missing. > > Grr. Paolo since you queued this, do you mind fixing directly? > Please write it here and I'll paste it in place. Paolo
On 10/06/20 18:08, Philippe Mathieu-Daudé wrote: > On 10/6/20 6:04 PM, Laszlo Ersek wrote: >> On 10/06/20 17:51, Richard Henderson wrote: >>> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >>>> +++ b/hw/nvram/fw_cfg-interface.c >>>> @@ -0,0 +1,15 @@ >>>> +#include "qemu/osdep.h" >>>> +#include "hw/nvram/fw_cfg.h" >>> >>> License boilerplate missing. >>> >>> r~ >>> >> >> Hrmpf, so easy to forget about that, especially in review :/ > > Although easily scriptable if we consider SPDX identifiers... ... Hm, "scripts/checkpatch.pl" already checks for SPDX, but only as an exception to the ban on "//" comments :) See commit 8d061278d385 ("checkpatch: allow SPDX-License-Identifier", 2019-06-03). Laszlo
On 10/6/20 6:15 PM, Paolo Bonzini wrote: > On 06/10/20 18:02, Philippe Mathieu-Daudé wrote: >> On 10/6/20 5:51 PM, Richard Henderson wrote: >>> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote: >>>> +++ b/hw/nvram/fw_cfg-interface.c >>>> @@ -0,0 +1,15 @@ >>>> +#include "qemu/osdep.h" >>>> +#include "hw/nvram/fw_cfg.h" >>> >>> License boilerplate missing. >> >> Grr. Paolo since you queued this, do you mind fixing directly? >> > > Please write it here and I'll paste it in place. /* * QEMU Firmware configuration device emulation (QOM interfaces) * * Copyright 2020 Red Hat, Inc. * * SPDX-License-Identifier: GPL-2.0-or-later */ Thanks! Phil.